Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1180)

Unified Diff: Source/devtools/front_end/timeline/TimelinePanel.js

Issue 1273363002: Devtools UI: Show multiple shortcuts, show more shortcuts (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/sources/module.json ('k') | Source/devtools/front_end/timeline/module.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/timeline/TimelinePanel.js
diff --git a/Source/devtools/front_end/timeline/TimelinePanel.js b/Source/devtools/front_end/timeline/TimelinePanel.js
index d37b2416bb0fbd2daf5ff63f3da8863c711d1954..7027d29e497cb86bbc7a542c80f4721609ee68b8 100644
--- a/Source/devtools/front_end/timeline/TimelinePanel.js
+++ b/Source/devtools/front_end/timeline/TimelinePanel.js
@@ -154,6 +154,12 @@ WebInspector.TimelinePanel.prototype = {
style.textContent = Object.values(categories).map(WebInspector.TimelineUIUtils.createStyleRuleForCategory).join("\n");
this.element.ownerDocument.head.appendChild(style);
}
+ WebInspector.context.setFlavor(WebInspector.TimelinePanel, this);
+ },
+
+ willHide: function()
+ {
+ WebInspector.context.setFlavor(WebInspector.TimelinePanel, null);
},
/**
@@ -303,8 +309,7 @@ WebInspector.TimelinePanel.prototype = {
{
this._panelToolbar = new WebInspector.Toolbar(this.element);
- this.toggleTimelineButton = new WebInspector.ToolbarButton("Record timeline", "record-toolbar-item");
- this.toggleTimelineButton.addEventListener("click", this._toggleTimelineButtonClicked, this);
+ this.toggleTimelineButton = WebInspector.ToolbarButton.createActionButton("timeline.toggle-recording");
this._panelToolbar.appendToolbarItem(this.toggleTimelineButton);
this._updateToggleTimelineButton(false);
@@ -477,7 +482,6 @@ WebInspector.TimelinePanel.prototype = {
_registerShortcuts: function()
{
- this.registerShortcuts(WebInspector.ShortcutsScreen.TimelinePanelShortcuts.StartStopRecording, this._toggleTimelineButtonClicked.bind(this));
this.registerShortcuts(WebInspector.ShortcutsScreen.TimelinePanelShortcuts.SaveToFile, this._saveToFile.bind(this));
this.registerShortcuts(WebInspector.ShortcutsScreen.TimelinePanelShortcuts.LoadFromFile, this._selectFileToLoad.bind(this));
this.registerShortcuts(WebInspector.ShortcutsScreen.TimelinePanelShortcuts.JumpToPreviousFrame, this._jumpToFrame.bind(this, -1));
@@ -1799,3 +1803,25 @@ WebInspector.LoadTimelineHandler.prototype = {
WebInspector.TimelinePanel.instance()._loadFromURL(value);
}
}
+
+/**
+ * @constructor
+ * @implements {WebInspector.ActionDelegate}
+ */
+WebInspector.TimelinePanel.RecordActionDelegate = function()
+{
+}
+
+WebInspector.TimelinePanel.RecordActionDelegate.prototype = {
+ /**
+ * @override
+ * @param {!WebInspector.Context} context
+ * @param {string} actionId
+ */
+ handleAction: function(context, actionId)
+ {
+ var panel = WebInspector.context.flavor(WebInspector.TimelinePanel);
+ console.assert(panel && panel instanceof WebInspector.TimelinePanel);
+ panel._toggleTimelineButtonClicked();
+ }
+}
« no previous file with comments | « Source/devtools/front_end/sources/module.json ('k') | Source/devtools/front_end/timeline/module.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698