Devtools UI: Show multiple shortcuts, show more shortcuts

Source/devtools/front_end/timeline/TimelinePanel.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 285 matching lines @@
             this._recordingOptionUIControls = [];
         var checkboxItem = new WebInspector.ToolbarCheckbox(name, tooltip, setting);
         this._recordingOptionUIControls.push(checkboxItem);
         return checkboxItem;
     },
 
     _createToolbarItems: function()
     {
         this._panelToolbar = new WebInspector.Toolbar(this.element);
 
-        this.toggleTimelineButton = new WebInspector.ToolbarButton("Record timeline", "record-toolbar-item");
-        this.toggleTimelineButton.addEventListener("click", this._toggleTimelineButtonClicked, this);
+        this.toggleTimelineButton = WebInspector.ToolbarButton.createActionButton("timeline.toggle-recording");
         this._panelToolbar.appendToolbarItem(this.toggleTimelineButton);
         this._updateToggleTimelineButton(false);
 
         var clearButton = new WebInspector.ToolbarButton(WebInspector.UIString("Clear recording"), "clear-toolbar-item");
         clearButton.addEventListener("click", this._onClearButtonClick, this);
         this._panelToolbar.appendToolbarItem(clearButton);
         this._panelToolbar.appendSeparator();
 
         this._filterBar = this._createFilterBar();
         this._panelToolbar.appendToolbarItem(this._filterBar.filterButton());
@@ skipping 152 matching lines @@
         this._dropTarget.setEnabled(!this._operationInProgress);
 
         this._progressToolbarItem.setVisible(this._operationInProgress);
         this._progressToolbarItem.element.removeChildren();
         if (indicator)
             this._progressToolbarItem.element.appendChild(indicator.element);
     },
 
     _registerShortcuts: function()
     {
-        this.registerShortcuts(WebInspector.ShortcutsScreen.TimelinePanelShortcuts.StartStopRecording, this._toggleTimelineButtonClicked.bind(this));
         this.registerShortcuts(WebInspector.ShortcutsScreen.TimelinePanelShortcuts.SaveToFile, this._saveToFile.bind(this));
         this.registerShortcuts(WebInspector.ShortcutsScreen.TimelinePanelShortcuts.LoadFromFile, this._selectFileToLoad.bind(this));
         this.registerShortcuts(WebInspector.ShortcutsScreen.TimelinePanelShortcuts.JumpToPreviousFrame, this._jumpToFrame.bind(this, -1));
         this.registerShortcuts(WebInspector.ShortcutsScreen.TimelinePanelShortcuts.JumpToNextFrame, this._jumpToFrame.bind(this, 1));
     },
 
     _createFileSelector: function()
     {
         if (this._fileSelectorElement)
             this._fileSelectorElement.remove();
@@ skipping 1303 matching lines @@
     /**
      * @override
      * @param {string} value
      */
     handleQueryParam: function(value)
     {
         WebInspector.TimelinePanel.show();
         WebInspector.TimelinePanel.instance()._loadFromURL(value);
     }
 }
+
+/**
+ * @constructor
+ * @implements {WebInspector.ActionDelegate}
+ */
+WebInspector.TimelinePanel.RecordActionDelegate = function()
+{
+}
+
+WebInspector.TimelinePanel.RecordActionDelegate.prototype = {
+    /**
+     * @override
+     * @param {!WebInspector.Context} context
+     * @param {string} actionId
+     */
+    handleAction: function(context, actionId)
+    {
+        if (WebInspector.inspectorView.currentPanel().name !== "timeline")

[samli, 2015/08/21 02:41:12]

Not sure how to better handle this. Couldn't find anything in context that would
help.

In the tests, the timeline record button is clicked while the elements panel is
open. There was no action before, so this triggered directly.
This check is necessary because the keyboard shortcut triggers actions in both
timeline/profiles.

[pfeldman, 2015/08/21 18:21:09]

For example, we could add timeline panel's instance by
WebInspector.TimelinePanel flavor in wasShown and remove it in willHide. We then
require this flavor to be non-empty via specifying the context in the
descriptor.

[samli, 2015/08/28 01:24:28]

Done and fixed test. PTAL.

+            return;
+        WebInspector.TimelinePanel.instance()._toggleTimelineButtonClicked();
+    }
+}