Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 1273343002: fix testChecker to include test inside (Closed)

Created:
5 years, 4 months ago by Jennifer Messerly
Modified:
5 years, 4 months ago
Reviewers:
Leaf, Bob Nystrom
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+658 lines, -721 lines) Patch
M test/checker/checker_test.dart View 78 chunks +271 lines, -402 lines 0 comments Download
M test/checker/inferred_type_test.dart View 57 chunks +346 lines, -281 lines 0 comments Download
M test/testing.dart View 2 chunks +41 lines, -38 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
painful to refactor, but looks much better now! Thanks for the suggestion Bob! as a ...
5 years, 4 months ago (2015-08-07 01:31:30 UTC) #3
Bob Nystrom
LGTM!
5 years, 4 months ago (2015-08-07 16:00:20 UTC) #4
Leaf
lgtm
5 years, 4 months ago (2015-08-07 16:10:53 UTC) #5
Jennifer Messerly
5 years, 4 months ago (2015-08-07 16:59:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bc642022c05abafff83e945994138c93944e8d4a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698