Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1642)

Unified Diff: sync/util/data_type_histogram.cc

Issue 1273303002: Measuring data use of different ModelTypes in Sync Service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@NewServices
Patch Set: Changing the recording macro to a recording function. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/util/data_type_histogram.cc
diff --git a/sync/util/data_type_histogram.cc b/sync/util/data_type_histogram.cc
new file mode 100644
index 0000000000000000000000000000000000000000..db6408fc8df646dedd8b1a1af6a4e09fefbb49e4
--- /dev/null
+++ b/sync/util/data_type_histogram.cc
@@ -0,0 +1,15 @@
+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
Alexei Svitkine (slow) 2015/08/24 21:27:00 Nit: No (c) for new comments.
amohammadkhan 2015/08/24 22:52:40 Done.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "sync/util/data_type_histogram.h"
+
+#include <string>
Alexei Svitkine (slow) 2015/08/24 21:27:00 This include should be in the header.
amohammadkhan 2015/08/24 22:52:40 Done.
+
+#include "base/metrics/sparse_histogram.h"
+
+void SyncRecordDatatypeBin(std::string name, int sample, int value) {
+ base::HistogramBase* histogram = base::SparseHistogram::FactoryGet(
Alexei Svitkine (slow) 2015/08/24 21:27:00 This is indented too much.
amohammadkhan 2015/08/24 22:52:40 Done.
+ name, base::HistogramBase::kUmaTargetedHistogramFlag);
+ histogram->AddCount(sample, value);
+}

Powered by Google App Engine
This is Rietveld 408576698