Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Unified Diff: sync/engine/commit.cc

Issue 1273303002: Measuring data use of different ModelTypes in Sync Service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@NewServices
Patch Set: Updating some of the comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sync/engine/directory_update_handler.cc » ('j') | sync/engine/syncer_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/commit.cc
diff --git a/sync/engine/commit.cc b/sync/engine/commit.cc
index f607be4c8b4e91499e2d1184c9c8d491d6b0d7ba..3c20f693c1c8f263be8c9639a81db413afa29c35 100644
--- a/sync/engine/commit.cc
+++ b/sync/engine/commit.cc
@@ -13,6 +13,7 @@
#include "sync/internal_api/public/events/commit_request_event.h"
#include "sync/internal_api/public/events/commit_response_event.h"
#include "sync/sessions/sync_session.h"
+#include "sync/util/data_type_histogram.h"
namespace syncer {
@@ -70,11 +71,21 @@ Commit* Commit::Init(
enabled_types,
commit_message);
+ int previous_message_size = message.ByteSize();
// Finally, serialize all our contributions.
for (std::map<ModelType, CommitContribution*>::const_iterator it =
contributions.begin();
it != contributions.end(); ++it) {
it->second->AddToCommitMessage(&message);
+ int current_entry_size = message.ByteSize() - previous_message_size;
+ previous_message_size = message.ByteSize();
+ if (current_entry_size > 0) {
+ UMA_HISTOGRAM_SPARSE_SLOWLY_WITH_VALUE("DataUse.Sync.Upload.Bytes",
+ ModelTypeToHistogramInt(it->first),
+ current_entry_size);
+ }
+ UMA_HISTOGRAM_SPARSE_SLOWLY("DataUse.Sync.Upload.Count",
+ ModelTypeToHistogramInt(it->first));
}
// If we made it this far, then we've successfully prepared a commit message.
« no previous file with comments | « no previous file | sync/engine/directory_update_handler.cc » ('j') | sync/engine/syncer_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698