Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: sync/util/data_type_histogram.h

Issue 1273303002: Measuring data use of different ModelTypes in Sync Service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@NewServices
Patch Set: Changing the initialization of vectors in syncer_unittest.cc Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sync/sync.gyp ('k') | sync/util/data_type_histogram.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SYNC_UTIL_DATA_TYPE_HISTOGRAM_H_ 5 #ifndef SYNC_UTIL_DATA_TYPE_HISTOGRAM_H_
6 #define SYNC_UTIL_DATA_TYPE_HISTOGRAM_H_ 6 #define SYNC_UTIL_DATA_TYPE_HISTOGRAM_H_
7 7
8 #include "base/metrics/histogram.h" 8 #include <string>
9
10 #include "base/metrics/histogram_macros.h"
9 #include "base/time/time.h" 11 #include "base/time/time.h"
10 #include "sync/internal_api/public/base/model_type.h" 12 #include "sync/internal_api/public/base/model_type.h"
11 13
14 // This function adds |value| to |sample| bucket of histogram |name|. |value|
15 // should be greater or equal to 1 and |name| can be variable. DataTypes are
16 // mapped to proper |sample| bucket by using ModelTypeToHistogramInt() function.
17 // So different DataTypes play the role of different buckets in this histogram.
18 void SyncRecordDatatypeBin(const std::string& name, int sample, int value);
19
12 // For now, this just implements UMA_HISTOGRAM_LONG_TIMES. This can be adjusted 20 // For now, this just implements UMA_HISTOGRAM_LONG_TIMES. This can be adjusted
13 // if we feel the min, max, or bucket count amount are not appropriate. 21 // if we feel the min, max, or bucket count amount are not appropriate.
14 #define SYNC_FREQ_HISTOGRAM(name, time) UMA_HISTOGRAM_CUSTOM_TIMES( \ 22 #define SYNC_FREQ_HISTOGRAM(name, time) UMA_HISTOGRAM_CUSTOM_TIMES( \
15 name, time, base::TimeDelta::FromMilliseconds(1), \ 23 name, time, base::TimeDelta::FromMilliseconds(1), \
16 base::TimeDelta::FromHours(1), 50) 24 base::TimeDelta::FromHours(1), 50)
17 25
18 // Helper macro for datatype specific histograms. For each datatype, invokes 26 // Helper macro for datatype specific histograms. For each datatype, invokes
19 // a pre-defined PER_DATA_TYPE_MACRO(type_str), where |type_str| is the string 27 // a pre-defined PER_DATA_TYPE_MACRO(type_str), where |type_str| is the string
20 // version of the datatype. 28 // version of the datatype.
21 // 29 //
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 case ::syncer::PROXY_TABS: \ 146 case ::syncer::PROXY_TABS: \
139 PER_DATA_TYPE_MACRO("Tabs"); \ 147 PER_DATA_TYPE_MACRO("Tabs"); \
140 break; \ 148 break; \
141 default: \ 149 default: \
142 NOTREACHED() << "Unknown datatype " \ 150 NOTREACHED() << "Unknown datatype " \
143 << ::syncer::ModelTypeToString(datatype); \ 151 << ::syncer::ModelTypeToString(datatype); \
144 } \ 152 } \
145 } while (0) 153 } while (0)
146 154
147 #endif // SYNC_UTIL_DATA_TYPE_HISTOGRAM_H_ 155 #endif // SYNC_UTIL_DATA_TYPE_HISTOGRAM_H_
OLDNEW
« no previous file with comments | « sync/sync.gyp ('k') | sync/util/data_type_histogram.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698