Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef SYNC_UTIL_DATA_TYPE_HISTOGRAM_H_ | 5 #ifndef SYNC_UTIL_DATA_TYPE_HISTOGRAM_H_ |
| 6 #define SYNC_UTIL_DATA_TYPE_HISTOGRAM_H_ | 6 #define SYNC_UTIL_DATA_TYPE_HISTOGRAM_H_ |
| 7 | 7 |
| 8 #include "base/metrics/histogram.h" | 8 #include "base/metrics/histogram.h" |
| 9 #include "base/metrics/sparse_histogram.h" | |
| 9 #include "base/time/time.h" | 10 #include "base/time/time.h" |
| 10 #include "sync/internal_api/public/base/model_type.h" | 11 #include "sync/internal_api/public/base/model_type.h" |
| 11 | 12 |
| 13 // This function adds |value| to |sample| bucket of histogram |name|. |value| | |
| 14 // should be greater or equal to 1 and |name| can be variable. DataTypes are | |
| 15 // mapped to proper |sample| bucket by using ModelTypeToHistogramInt() function. | |
| 16 // So different DataTypes play the role of different buckets in this histogram. | |
| 17 void SyncRecordDatatypeBin(std::string name, int sample, int value); | |
|
Alexei Svitkine (slow)
2015/08/24 21:27:00
Nit: const std::string&
amohammadkhan
2015/08/24 22:52:40
Done.
| |
| 18 | |
| 12 // For now, this just implements UMA_HISTOGRAM_LONG_TIMES. This can be adjusted | 19 // For now, this just implements UMA_HISTOGRAM_LONG_TIMES. This can be adjusted |
| 13 // if we feel the min, max, or bucket count amount are not appropriate. | 20 // if we feel the min, max, or bucket count amount are not appropriate. |
| 14 #define SYNC_FREQ_HISTOGRAM(name, time) UMA_HISTOGRAM_CUSTOM_TIMES( \ | 21 #define SYNC_FREQ_HISTOGRAM(name, time) UMA_HISTOGRAM_CUSTOM_TIMES( \ |
| 15 name, time, base::TimeDelta::FromMilliseconds(1), \ | 22 name, time, base::TimeDelta::FromMilliseconds(1), \ |
| 16 base::TimeDelta::FromHours(1), 50) | 23 base::TimeDelta::FromHours(1), 50) |
| 17 | 24 |
| 18 // Helper macro for datatype specific histograms. For each datatype, invokes | 25 // Helper macro for datatype specific histograms. For each datatype, invokes |
| 19 // a pre-defined PER_DATA_TYPE_MACRO(type_str), where |type_str| is the string | 26 // a pre-defined PER_DATA_TYPE_MACRO(type_str), where |type_str| is the string |
| 20 // version of the datatype. | 27 // version of the datatype. |
| 21 // | 28 // |
| (...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 138 case ::syncer::PROXY_TABS: \ | 145 case ::syncer::PROXY_TABS: \ |
| 139 PER_DATA_TYPE_MACRO("Tabs"); \ | 146 PER_DATA_TYPE_MACRO("Tabs"); \ |
| 140 break; \ | 147 break; \ |
| 141 default: \ | 148 default: \ |
| 142 NOTREACHED() << "Unknown datatype " \ | 149 NOTREACHED() << "Unknown datatype " \ |
| 143 << ::syncer::ModelTypeToString(datatype); \ | 150 << ::syncer::ModelTypeToString(datatype); \ |
| 144 } \ | 151 } \ |
| 145 } while (0) | 152 } while (0) |
| 146 | 153 |
| 147 #endif // SYNC_UTIL_DATA_TYPE_HISTOGRAM_H_ | 154 #endif // SYNC_UTIL_DATA_TYPE_HISTOGRAM_H_ |
| OLD | NEW |