Measuring data use of different ModelTypes in Sync Service.

sync/engine/commit.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/engine/commit.h"
 
 #include "base/trace_event/trace_event.h"
 #include "sync/engine/commit_contribution.h"
 #include "sync/engine/commit_processor.h"
 #include "sync/engine/commit_util.h"
 #include "sync/engine/syncer.h"
 #include "sync/engine/syncer_proto_util.h"
 #include "sync/internal_api/public/events/commit_request_event.h"
 #include "sync/internal_api/public/events/commit_response_event.h"
 #include "sync/sessions/sync_session.h"
+#include "sync/util/data_type_histogram.h"
 
 namespace syncer {
 
 Commit::Commit(ContributionMap contributions,
                const sync_pb::ClientToServerMessage& message,
                ExtensionsActivity::Records extensions_activity_buffer)
     : contributions_(contributions.Pass()),
       message_(message),
       extensions_activity_buffer_(extensions_activity_buffer),
       cleaned_up_(false) {
@@ skipping 37 matching lines @@
         extensions_activity,
         &extensions_activity_buffer,
         commit_message);
   }
 
   // Set the client config params.
   commit_util::AddClientConfigParamsToMessage(
       enabled_types,
       commit_message);
 
+  int previous_message_size = message.ByteSize();
   // Finally, serialize all our contributions.
   for (std::map<ModelType, CommitContribution*>::const_iterator it =
            contributions.begin();
        it != contributions.end(); ++it) {

[Alexei Svitkine (slow), 2015/08/24 21:27:00]

Nit: Switch to C++11 for loop

[amohammadkhan, 2015/08/24 22:52:40]

Done.

     it->second->AddToCommitMessage(&message);
+    int current_entry_size = message.ByteSize() - previous_message_size;
+    previous_message_size = message.ByteSize();
+    if (current_entry_size > 0) {
+      SyncRecordDatatypeBin("DataUse.Sync.Upload.Bytes",
+                            ModelTypeToHistogramInt(it->first),
+                            current_entry_size);
+    }
+    UMA_HISTOGRAM_SPARSE_SLOWLY("DataUse.Sync.Upload.Count",
+                                ModelTypeToHistogramInt(it->first));

[Alexei Svitkine (slow), 2015/08/24 21:27:00]

Nit: Since you use ModelTypeToHistogramInt() twice, use a local var for it.

[amohammadkhan, 2015/08/24 22:52:40]

Done.

   }
 
   // If we made it this far, then we've successfully prepared a commit message.
   return new Commit(contributions.Pass(), message, extensions_activity_buffer);
 }
 
 SyncerError Commit::PostAndProcessResponse(
     sessions::NudgeTracker* nudge_tracker,
     sessions::SyncSession* session,
     sessions::StatusController* status,
@@ skipping 84 matching lines @@
 
 void Commit::CleanUp() {
   for (ContributionMap::const_iterator it = contributions_.begin();
        it != contributions_.end(); ++it) {
     it->second->CleanUp();
   }
   cleaned_up_ = true;
 }
 
 }  // namespace syncer