Measuring data use of different ModelTypes in Sync Service.

net/url_request/data_use_measurement.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/hash.h"
 #include "base/metrics/histogram.h"
 #include "base/metrics/sparse_histogram.h"
 #include "net/base/network_change_notifier.h"
@@ skipping 117 matching lines @@
   }
   std::string serviceHistogramName = "DataUse.Service." + service_name;
   std::string combinedHistogramName =
       "DataUse.Services" + first_suffix + second_suffix + third_suffix;
   UMA_HISTOGRAM_SPARSE_SLOWLY_WITH_VALUE(
       combinedHistogramName, base::Hash(service_name), message_size);
   TRAFFIC_MEASUREMENT_UMA_HISTOGRAM(serviceHistogramName, message_size);
 }
 
 }  // namespace
+void SparseDataUseReport(const std::string& histogram_name,

[bengr, 2015/08/07 17:13:37]

Add a blank line above.

[amohammadkhan, 2015/08/07 18:52:30]

Done.

+                         int value,
+                         int count) {
+  if (count > 0)
+    UMA_HISTOGRAM_SPARSE_SLOWLY_WITH_VALUE(histogram_name, value, count);
+  else
+    LOG(ERROR) << "Ali1 zero or negative count " << count;

[bengr, 2015/08/07 17:13:37]

What is Ali1?

[amohammadkhan, 2015/08/07 18:52:30]

Sorry, basically this LOG(ERROR) was for testing to see if we have any negative
or zero values and it should be removed.

But beside that I have a question. Because at first I changed
Data_use_measurement to add a function for measuring Sync data use. But I had to
include it (net/url_request/data_use_measurement.h) in Sync files that I wasn't
sure it is Okay or not. So I added my Macro to those files and didn't use
function of data_use_measurement. So I wanted to ask you which approach is
better and remove the code for the other one. Because now I have the code for
both of approaches (The added function in data_use_measurement and the Macro in
Sync files)

+}
 
 void DataUseReport(const std::string& service_name,
                    const net::URLFetcher* fetcher) {
 #if defined(OS_ANDROID)
   if (!listener_made) {
     listener_made = true;
     app_listener = new base::android::ApplicationStatusListener(
         base::Bind(&OnApplicationStateChange));
   }
 #endif
   int total_upload_bytes = fetcher->GetBytesSentSize();
   int total_received_bytes = fetcher->GetBytesReceivedSize();
   ReportDataUsage(service_name, UPLOAD, total_upload_bytes);
   ReportDataUsage(service_name, DOWNLOAD, total_received_bytes);
 }