pkg/intl/lib/src/file_data_reader.dart - Issue 12733003: Adds facilities for extracting Intl.message calls and generating code from translations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/intl/lib/src/file_data_reader.dart

Issue 12733003: Adds facilities for extracting Intl.message calls and generating code from translations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fixes from review comments, also made tests more robust, removed scheduled_test dependency Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/intl/lib/intl.dart ('K') | « pkg/intl/lib/message_lookup_local.dart ('k') | pkg/intl/lib/src/intl_helpers.dart » ('j') | pkg/intl/test/message_extraction/message_extraction_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/intl/lib/src/file_data_reader.dart

diff --git a/pkg/intl/lib/src/file_data_reader.dart b/pkg/intl/lib/src/file_data_reader.dart

index 1c0b4ad442644b4c29905afdfeb299e746db2e01..4e6c2aef7aa29ef7db77d157b74ea450b39e9f35 100644

--- a/pkg/intl/lib/src/file_data_reader.dart

+++ b/pkg/intl/lib/src/file_data_reader.dart

@@ -10,6 +10,7 @@

library file_data_reader;

import 'dart:async';

+import 'package:pathos/path.dart';

import 'dart:io';

import 'intl_helpers.dart';

@@ -22,7 +23,7 @@ class FileDataReader implements LocaleDataReader {

/// Read the locale data found for [locale] on our [path].

Future read(String locale) {

- var file = new File('$path$locale.json');

+ var file = new File(join(path, '$locale.json'));

return file.readAsString();

}