Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: pkg/intl/lib/date_symbol_data_file.dart

Issue 12733003: Adds facilities for extracting Intl.message calls and generating code from translations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixes from review comments, also made tests more robust, removed scheduled_test dependency Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/intl/lib/date_symbol_data_file.dart
diff --git a/pkg/intl/lib/date_symbol_data_file.dart b/pkg/intl/lib/date_symbol_data_file.dart
index 767e89bf86da9f62bb228c74d0cb05549712edeb..5c599f44f8ce5197214165a914b3bb2d21a13ac0 100644
--- a/pkg/intl/lib/date_symbol_data_file.dart
+++ b/pkg/intl/lib/date_symbol_data_file.dart
@@ -14,7 +14,7 @@ import "date_symbols.dart";
import "src/lazy_locale_data.dart";
import 'src/date_format_internal.dart';
import 'src/file_data_reader.dart';
-import 'dart:io';
+import 'package:pathos/path.dart' as path;
part "src/data/dates/localeList.dart";
@@ -24,11 +24,11 @@ part "src/data/dates/localeList.dart";
* The [path] parameter should end with a directory separator appropriate
* for the platform.
*/
-Future initializeDateFormatting(String locale, String path) {
- var reader = new FileDataReader('${path}symbols${Platform.pathSeparator}');
+Future initializeDateFormatting(String locale, String filePath) {
+ var reader = new FileDataReader(path.join(filePath, 'symbols'));
initializeDateSymbols(() => new LazyLocaleData(
reader, _createDateSymbol, availableLocalesForDateFormatting));
- var reader2 = new FileDataReader('${path}patterns${Platform.pathSeparator}');
+ var reader2 = new FileDataReader(path.join(filePath, 'patterns'));
initializeDatePatterns(() => new LazyLocaleData(
reader2, (x) => x, availableLocalesForDateFormatting));
return initializeIndividualLocaleDateFormatting(

Powered by Google App Engine
This is Rietveld 408576698