Updates to base unittests so they run correctly in libchrome on Android

Updates to base unittests so they run correctly in libchrome on Android

Parallel change to https://android-review.googlesource.com/#/c/163293/
(does not include changes being made to base/command_line_unittest
that are fixing temporary runner issues, since the runner is fine here)

BUG=22884411, 22947438
Committed: https://crrev.com/e89963accb5f3a9d93b8007b22fc79c0120eb794
Cr-Commit-Position: refs/heads/master@{#343126}

[arihc, 2015-08-06 19:48:03]

arihc@google.com changed reviewers:
+ bsimonnet@chromium.org, derat@chromium.org

[Daniel Erat, 2015-08-06 20:13:18]

derat@chromium.org changed reviewers:
+ brettw@chromium.org

[Daniel Erat, 2015-08-06 20:13:18]

you need someone from src/base/OWNERS to approve this:

% cat OWNERS
ben@chromium.org
brettw@chromium.org
cpu@chromium.org
darin@chromium.org
jam@chromium.org

arbitrarily choosing brett.

[Daniel Erat, 2015-08-06 23:25:09]

https://codereview.chromium.org/1273243002/diff/1/base/files/file_util_posix.cc
File base/files/file_util_posix.cc (right):

https://codereview.chromium.org/1273243002/diff/1/base/files/file_util_posix....
base/files/file_util_posix.cc:458: *path = FilePath("/data/local/tmp");
i think that this one shouldn't be upstreamed; __BRILLO__ is just something
we're setting in the aosp repo for hacks.

[arihc, 2015-08-06 23:51:22]

https://codereview.chromium.org/1273243002/diff/1/base/files/file_util_posix.cc
File base/files/file_util_posix.cc (right):

https://codereview.chromium.org/1273243002/diff/1/base/files/file_util_posix....
base/files/file_util_posix.cc:458: *path = FilePath("/data/local/tmp");
On 2015/08/06 23:25:09, Daniel Erat wrote:
> i think that this one shouldn't be upstreamed; __BRILLO__ is just something
> we're setting in the aosp repo for hacks.

Done.

[Daniel Erat, 2015-08-10 15:41:31]

thanks, lgtm!

brett, any comments?

[brettw, 2015-08-10 17:29:20]

lgtm, thanks

[chromium-reviews, 2015-08-10 21:46:18]

1 line was added, if you wouldn't mind looking again to confirm it's ok

On Mon, Aug 10, 2015 at 10:29 AM, <brettw@chromium.org> wrote:

> lgtm, thanks
>
> https://codereview.chromium.org/1273243002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Daniel Erat, 2015-08-10 21:51:17]

https://codereview.chromium.org/1273243002/diff/40001/base/command_line_unitt...
File base/command_line_unittest.cc (right):

https://codereview.chromium.org/1273243002/diff/40001/base/command_line_unitt...
base/command_line_unittest.cc:382: // whether or not the test runner does so.
just for brett's benefit since we discussed this on the other bug: the chromium
test runner calls CommandLine::Init(), which seems fairly gross since this test
later exercises the singleton. on the brillo side, the default gtest harness is
being used, so Init() doesn't get called automatically.

calling Init() explicitly here seems reasonable to me: the test is still
checking that a later call to Init() returns false and doesn't recreate the
singleton, but it also makes the test stop depending on outside code calling
Init() first.

[Daniel Erat, 2015-08-12 18:25:41]

The CQ bit was checked by derat@chromium.org

[Daniel Erat, 2015-08-12 18:25:41]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org,
derat@chromium.org
Link to the patchset: https://codereview.chromium.org/1273243002/#ps40001
(title: "Change to command_line_unittest amended for upstream compatibility")

[commit-bot: I haz the power, 2015-08-12 18:25:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1273243002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1273243002/40001

[commit-bot: I haz the power, 2015-08-12 18:41:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-12 18:41:59]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[arihc, 2015-08-12 20:23:43]

The CQ bit was checked by arihc@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-08-12 20:24:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1273243002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1273243002/60001

[commit-bot: I haz the power, 2015-08-12 21:29:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-12 21:29:15]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[arihc, 2015-08-12 23:01:37]

The CQ bit was checked by arihc@google.com to run a CQ dry run

[arihc, 2015-08-12 23:01:56]

The CQ bit was unchecked by arihc@google.com

[arihc, 2015-08-12 23:01:57]

The CQ bit was checked by arihc@google.com

[arihc, 2015-08-12 23:01:57]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org,
derat@chromium.org
Link to the patchset: https://codereview.chromium.org/1273243002/#ps80001
(title: "Existing tests using ScopedLocale are wrapped by OS_LINUX, trying
that")

[commit-bot: I haz the power, 2015-08-12 23:02:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1273243002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1273243002/80001

[commit-bot: I haz the power, 2015-08-12 23:46:00]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-08-12 23:46:36]

Patchset 5 (id:??) landed as
https://crrev.com/e89963accb5f3a9d93b8007b22fc79c0120eb794
Cr-Commit-Position: refs/heads/master@{#343126}