Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1273213004: Stop using TCP TURN servers as STUN servers. (Closed)

Created:
5 years, 4 months ago by Taylor_Brandstetter
Modified:
5 years, 4 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop using TCP TURN servers as STUN servers. UDP TURN servers are already used as STUN servers at the PortAllocator level, so we don't need to do anything any longer at the PeerConnectionDependencyFactory level. BUG=webrtc:4215 Committed: https://crrev.com/ccbaa51b745b4ce2eaeb2dbe5fbfe43270dff008 Cr-Commit-Position: refs/heads/master@{#342350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Taylor_Brandstetter
5 years, 4 months ago (2015-08-06 20:44:11 UTC) #2
tommi (sloooow) - chröme
lgtm
5 years, 4 months ago (2015-08-07 12:28:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273213004/1
5 years, 4 months ago (2015-08-07 12:28:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 14:02:30 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 14:03:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ccbaa51b745b4ce2eaeb2dbe5fbfe43270dff008
Cr-Commit-Position: refs/heads/master@{#342350}

Powered by Google App Engine
This is Rietveld 408576698