Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1273203002: The compiler can generate smulbb perfectly well nowadays. (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

The compiler can generate smulbb perfectly well nowadays. BUG=skia:4117 Committed: https://skia.googlesource.com/skia/+/3848427d884b72114854c8eef9662691f23fae7b

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : parens #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -60 lines) Patch
M include/core/SkColorPriv.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M include/core/SkMath.h View 1 3 chunks +2 lines, -30 lines 0 comments Download
M include/core/SkPreConfig.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/core/SkMathPriv.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkScan_Antihair.cpp View 1 6 chunks +11 lines, -11 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm_neon.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/opts/SkBlitRow_opts_mips_dsp.cpp View 1 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273203002/1
5 years, 4 months ago (2015-08-06 18:20:36 UTC) #2
mtklein_C
5 years, 4 months ago (2015-08-06 18:24:32 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273203002/20001
5 years, 4 months ago (2015-08-06 18:25:25 UTC) #6
reed1
lgtm
5 years, 4 months ago (2015-08-06 18:25:53 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/2446)
5 years, 4 months ago (2015-08-06 18:43:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273203002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273203002/40001
5 years, 4 months ago (2015-08-07 15:40:37 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 15:48:15 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/3848427d884b72114854c8eef9662691f23fae7b

Powered by Google App Engine
This is Rietveld 408576698