chrome/renderer/resources/extensions/searchbox_api.js - Issue 12732005: Most visited thumbnails and favicons need id-based urls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/searchbox_api.js

Issue 12732005: Most visited thumbnails and favicons need id-based urls (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address estade's comments. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/resources/extensions/searchbox_api.js

diff --git a/chrome/renderer/resources/extensions/searchbox_api.js b/chrome/renderer/resources/extensions/searchbox_api.js

index 466299e06a95bb64a086511344158ba58fa9f162..24b2bc142cb9320382c8276949655c9a25b22921 100644

--- a/chrome/renderer/resources/extensions/searchbox_api.js

+++ b/chrome/renderer/resources/extensions/searchbox_api.js

@@ -330,14 +330,14 @@ if (!chrome.embeddedSearch) {

this.__defineGetter__('mostVisited', GetMostVisitedItemsWrapper);

this.__defineGetter__('themeBackgroundInfo', GetThemeBackgroundInfo);

- this.deleteMostVisitedItem = function(restrictId) {

- DeleteMostVisitedItem(restrictId);

+ this.deleteMostVisitedItem = function(restrictedId) {

+ DeleteMostVisitedItem(restrictedId);

};

this.undoAllMostVisitedDeletions = function() {

UndoAllMostVisitedDeletions();

};

- this.undoMostVisitedDeletion = function(restrictId) {

- UndoMostVisitedDeletion(restrictId);

+ this.undoMostVisitedDeletion = function(restrictedId) {

+ UndoMostVisitedDeletion(restrictedId);

};

this.navigateContentWindow = function(destination, disposition) {

NavigateNewTabPage(destination, disposition);

« no previous file with comments | « chrome/common/render_messages.h ('k') | chrome/renderer/searchbox/searchbox.h » ('j') | no next file with comments »