Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5573)

Unified Diff: chrome/browser/instant/instant_page.cc

Issue 12732005: Most visited thumbnails and favicons need id-based urls (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address estade's comments. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/instant/instant_page.h ('k') | chrome/browser/instant/instant_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/instant/instant_page.cc
diff --git a/chrome/browser/instant/instant_page.cc b/chrome/browser/instant/instant_page.cc
index 37496eea2497364e0667b9d0328210d090c89017..c89521dc8eb20572d83dbb05b9c97536e1eb1f21 100644
--- a/chrome/browser/instant/instant_page.cc
+++ b/chrome/browser/instant/instant_page.cc
@@ -95,8 +95,8 @@ void InstantPage::KeyCaptureChanged(bool is_key_capture_enabled) {
}
void InstantPage::SendMostVisitedItems(
- const std::vector<MostVisitedItem>& items) {
- Send(new ChromeViewMsg_InstantMostVisitedItemsChanged(routing_id(), items));
+ const std::vector<InstantMostVisitedItem>& items) {
+ Send(new ChromeViewMsg_SearchBoxMostVisitedItemsChanged(routing_id(), items));
}
InstantPage::InstantPage(Delegate* delegate)
@@ -173,11 +173,11 @@ bool InstantPage::OnMessageReceived(const IPC::Message& message) {
OnStopCapturingKeyStrokes);
IPC_MESSAGE_HANDLER(ChromeViewHostMsg_SearchBoxNavigate,
OnSearchBoxNavigate);
- IPC_MESSAGE_HANDLER(ChromeViewHostMsg_InstantDeleteMostVisitedItem,
+ IPC_MESSAGE_HANDLER(ChromeViewHostMsg_SearchBoxDeleteMostVisitedItem,
OnDeleteMostVisitedItem);
- IPC_MESSAGE_HANDLER(ChromeViewHostMsg_InstantUndoMostVisitedDeletion,
+ IPC_MESSAGE_HANDLER(ChromeViewHostMsg_SearchBoxUndoMostVisitedDeletion,
OnUndoMostVisitedDeletion);
- IPC_MESSAGE_HANDLER(ChromeViewHostMsg_InstantUndoAllMostVisitedDeletions,
+ IPC_MESSAGE_HANDLER(ChromeViewHostMsg_SearchBoxUndoAllMostVisitedDeletions,
OnUndoAllMostVisitedDeletions);
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
@@ -270,12 +270,12 @@ void InstantPage::OnSearchBoxNavigate(int page_id,
}
}
-void InstantPage::OnDeleteMostVisitedItem(const GURL& url) {
- delegate_->DeleteMostVisitedItem(url);
+void InstantPage::OnDeleteMostVisitedItem(uint64 most_visited_item_id) {
+ delegate_->DeleteMostVisitedItem(most_visited_item_id);
}
-void InstantPage::OnUndoMostVisitedDeletion(const GURL& url) {
- delegate_->UndoMostVisitedDeletion(url);
+void InstantPage::OnUndoMostVisitedDeletion(uint64 most_visited_item_id) {
+ delegate_->UndoMostVisitedDeletion(most_visited_item_id);
}
void InstantPage::OnUndoAllMostVisitedDeletions() {
« no previous file with comments | « chrome/browser/instant/instant_page.h ('k') | chrome/browser/instant/instant_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698