Most visited thumbnails and favicons need id-based urls

chrome/renderer/searchbox/searchbox_extension.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/searchbox/searchbox_extension.h"
 
 #include "base/i18n/rtl.h"
 #include "base/stringprintf.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
@@ skipping 45 matching lines @@
 // Converts std::string to V8 String.
 v8::Handle<v8::String> UTF8ToV8String(const std::string& s) {
   return v8::String::New(s.data(), s.size());
 }
 
 void Dispatch(WebKit::WebFrame* frame, const WebKit::WebString& script) {
   if (!frame) return;
   frame->executeScript(WebKit::WebScriptSource(script));
 }
 
+v8::Handle<v8::String> GenerateThumbnailURL(uint64 restricted_id) {
+  std::ostringstream ostr;
+  ostr << "chrome-search://thumb/" << restricted_id;

[palmer, 2013/03/11 20:42:31]

This seems kind of heavy-weight (including having to convert it to a string,
below). Maybe just use base/stringprintf.h (already #included)?

[dhollowa, 2013/03/11 23:27:59]

Done.  I was blindly copy/pasting...

+  GURL url = GURL(ostr.str());
+  return UTF8ToV8String(url.spec());
+}
+
+v8::Handle<v8::String> GenerateFaviconURL(uint64 restricted_id) {
+  std::ostringstream ostr;
+  ostr << "chrome-search://favicon/" << restricted_id;
+  GURL url = GURL(ostr.str());
+  return UTF8ToV8String(url.spec());
+}
+
 }  // namespace
 
 namespace extensions_v8 {
 
 static const char kSearchBoxExtensionName[] = "v8/EmbeddedSearch";
 
 static const char kDispatchChangeEventScript[] =
     "if (window.chrome &&"
     "    window.chrome.embeddedSearch &&"
     "    window.chrome.embeddedSearch.searchBox &&"
@@ skipping 789 matching lines @@
 
   SearchBox::Get(render_view)->ShowInstantOverlay(reason, height, units);
 
   return v8::Undefined();
 }
 
 // static
 v8::Handle<v8::Value> SearchBoxExtensionWrapper::GetMostVisitedItems(
     const v8::Arguments& args) {
   content::RenderView* render_view = GetRenderView();
-  if (!render_view) return v8::Undefined();
-
+  if (!render_view)
+    return v8::Undefined();
   DVLOG(1) << render_view << " GetMostVisitedItems";
 
-  const std::vector<MostVisitedItem>& items =
-      SearchBox::Get(render_view)->GetMostVisitedItems();
-  v8::Handle<v8::Array> items_array = v8::Array::New(items.size());
-  for (size_t i = 0; i < items.size(); ++i) {
+  SearchBox* search_box = SearchBox::Get(render_view);

[palmer, 2013/03/11 20:42:31]

Can |search_box| be declared const?

[dhollowa, 2013/03/11 23:27:59]

Yes. Done.

 
-    const string16 url = UTF8ToUTF16(items[i].url.spec());
-    const string16 host = UTF8ToUTF16(items[i].url.host());
-    int restrict_id =
-        SearchBox::Get(render_view)->UrlToRestrictedId(url);
-
+  const std::vector<InstantMostVisitedItem>& instant_mv_items =
+      search_box->GetMostVisitedItems();
+  v8::Handle<v8::Array> v8_mv_items = v8::Array::New(instant_mv_items.size());
+  for (size_t i = 0; i < instant_mv_items.size(); ++i) {
     // We set the "dir" attribute of the title, so that in RTL locales, a LTR
     // title is rendered left-to-right and truncated from the right. For
     // example, the title of http://msdn.microsoft.com/en-us/default.aspx is
     // "MSDN: Microsoft developer network". In RTL locales, in the New Tab
     // page, if the "dir" of this title is not specified, it takes Chrome UI's
     // directionality. So the title will be truncated as "soft developer
     // network". Setting the "dir" attribute as "ltr" renders the truncated
     // title as "MSDN: Microsoft D...". As another example, the title of
     // http://yahoo.com is "Yahoo!". In RTL locales, in the New Tab page, the
     // title will be rendered as "!Yahoo" if its "dir" attribute is not set to
     // "ltr".
     std::string direction;
-    if (base::i18n::StringContainsStrongRTLChars(items[i].title))
+    if (base::i18n::StringContainsStrongRTLChars(instant_mv_items[i].title))
       direction = kRTLHtmlTextDirection;
     else
       direction = kLTRHtmlTextDirection;
 
-    string16 title = items[i].title;
+    string16 title = instant_mv_items[i].title;
     if (title.empty())
-      title = url;
+      title = UTF8ToUTF16(instant_mv_items[i].url.spec());
 
     v8::Handle<v8::Object> item = v8::Object::New();
     item->Set(v8::String::New("rid"),
-              v8::Int32::New(restrict_id));
+              v8::Int32::New(instant_mv_items[i].restricted_id));
     item->Set(v8::String::New("thumbnailUrl"),
-              UTF16ToV8String(SearchBox::Get(render_view)->
-                              GenerateThumbnailUrl(restrict_id)));
+              GenerateThumbnailURL(instant_mv_items[i].restricted_id));
     item->Set(v8::String::New("faviconUrl"),
-              UTF16ToV8String(SearchBox::Get(render_view)->
-                              GenerateFaviconUrl(restrict_id)));
+              GenerateFaviconURL(instant_mv_items[i].restricted_id));
     item->Set(v8::String::New("title"),
               UTF16ToV8String(title));
-    item->Set(v8::String::New("domain"), UTF16ToV8String(host));
-    item->Set(v8::String::New("direction"),
-              UTF8ToV8String(direction));
+    item->Set(v8::String::New("domain"),
+              UTF8ToV8String(instant_mv_items[i].url.host()));
+    item->Set(v8::String::New("direction"), UTF8ToV8String(direction));
 
-    items_array->Set(i, item);
+    v8_mv_items->Set(i, item);
   }
-  return items_array;
+  return v8_mv_items;
 }
 
 // static
 v8::Handle<v8::Value> SearchBoxExtensionWrapper::DeleteMostVisitedItem(
     const v8::Arguments& args) {
   content::RenderView* render_view = GetRenderView();
   if (!render_view || !args.Length()) return v8::Undefined();
 
   DVLOG(1) << render_view << " DeleteMostVisitedItem";
   SearchBox::Get(render_view)->DeleteMostVisitedItem(args[0]->IntegerValue());
@@ skipping 129 matching lines @@
 void SearchBoxExtension::DispatchThemeChange(WebKit::WebFrame* frame) {
   Dispatch(frame, kDispatchThemeChangeEventScript);
 }
 
 // static
 void SearchBoxExtension::DispatchMostVisitedChanged(
     WebKit::WebFrame* frame) {
   Dispatch(frame, kDispatchMostVisitedChangedScript);
 }
 }  // namespace extensions_v8