Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: pkg/scheduled_test/test/scheduled_process_test.dart

Issue 12732004: Add a bunch of ugly debugging prints to figure out why the bots are failing. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/scheduled_test/lib/src/schedule.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/scheduled_test/test/scheduled_process_test.dart
diff --git a/pkg/scheduled_test/test/scheduled_process_test.dart b/pkg/scheduled_test/test/scheduled_process_test.dart
index 02a113c2cd5cd3067d2cf99c24e961f5a6498ecc..de94c96c668e8605c9c7e7b05dd7da59ed7bd3e2 100644
--- a/pkg/scheduled_test/test/scheduled_process_test.dart
+++ b/pkg/scheduled_test/test/scheduled_process_test.dart
@@ -118,31 +118,31 @@ void main() {
});
});
- // TODO(nweiz): re-enable this (issue 9022).
- // expectTestsPass("a process that ends while waiting for stdout shouldn't "
- // "block the test", () {
- // var errors;
- // test('test 1', () {
- // currentSchedule.onException.schedule(() {
- // errors = currentSchedule.errors;
- // });
- //
- // var process = startDartProcess('');
- // expect(process.nextLine(), completion(equals('hello')));
- // expect(process.nextLine(), completion(equals('world')));
- // process.shouldExit(0);
- // });
- //
- // test('test 2', () {
- // expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
- // expect(errors.length, equals(2));
- // expect(errors[0].error, isStateError);
- // expect(errors[0].error.message, equals("No elements"));
- // expect(errors[1].error, matches(r"^Process "
- // r"'[^']+[\\/]dart(\.exe)? [^']+' ended earlier than scheduled with "
- // r"exit code 0\."));
- // });
- // }, passing: ['test 2']);
+ expectTestsPass("a process that ends while waiting for stdout shouldn't "
+ "block the test", () {
+ print("beginning test: a process that ends while waiting for stdout shouldn't block the test");
+ var errors;
+ test('test 1', () {
+ currentSchedule.onException.schedule(() {
+ errors = currentSchedule.errors;
+ });
+
+ var process = startDartProcess('');
+ expect(process.nextLine(), completion(equals('hello')));
+ expect(process.nextLine(), completion(equals('world')));
+ process.shouldExit(0);
+ });
+
+ test('test 2', () {
+ expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
+ expect(errors.length, equals(2));
+ expect(errors[0].error, isStateError);
+ expect(errors[0].error.message, equals("No elements"));
+ expect(errors[1].error, matches(r"^Process "
+ r"'[^']+[\\/]dart(\.exe)? [^']+' ended earlier than scheduled with "
+ r"exit code 0\."));
+ });
+ }, passing: ['test 2']);
expectTestsPass("a process that ends during the task immediately before it's "
"scheduled to end shouldn't cause an error", () {
@@ -169,6 +169,7 @@ void main() {
});
expectTestsPass("nextLine throws an error if there's no more stdout", () {
+ print("beginning test: nextLine throws an error if there's no more stdout");
var errors;
test('test 1', () {
currentSchedule.onException.schedule(() {
@@ -208,6 +209,7 @@ void main() {
});
expectTestsPass("nextErrLine throws an error if there's no more stderr", () {
+ print("beginning test: nextErrLine throws an error if there's no more stdout");
var errors;
test('test 1', () {
currentSchedule.onException.schedule(() {
« no previous file with comments | « pkg/scheduled_test/lib/src/schedule.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698