Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3511)

Unified Diff: content/renderer/render_frame_impl_browsertest.cc

Issue 1273183002: Fix invalid C-style cast in RenderFrameImplTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl_browsertest.cc
diff --git a/content/renderer/render_frame_impl_browsertest.cc b/content/renderer/render_frame_impl_browsertest.cc
index ceb52cd626293343294bbb5938217a221e0e8bba..9ba0f70d814cd9ef1b074d0f6aefefbae879b7c6 100644
--- a/content/renderer/render_frame_impl_browsertest.cc
+++ b/content/renderer/render_frame_impl_browsertest.cc
@@ -110,7 +110,8 @@ class RenderFrameTestObserver : public RenderFrameObserver {
// RenderWidget.
TEST_F(RenderFrameImplTest, MAYBE_SubframeWidget) {
EXPECT_TRUE(frame_widget());
- EXPECT_NE(frame_widget(), (content::RenderWidget*)view_);
+ EXPECT_NE(frame_widget(),
+ static_cast<content::RenderViewImpl*>((view_)));
nasko 2015/08/06 18:08:33 This is not a correct cast. The subframe should ha
}
// Verify a subframe RenderWidget properly processes its viewport being
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698