Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

Issue 1273173002: Added Network Quality Estimator Real-time interface to Cronet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed remaining comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
index d9cc5578e7169c741dd1b7ec1095a251996df6bc..0fbac9b568db37e5051fdf9e38edb42a8d993877 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
@@ -18,6 +18,9 @@ import org.chromium.net.TestUrlRequestListener.ResponseStep;
import java.io.BufferedReader;
import java.io.File;
import java.io.FileReader;
+import java.util.LinkedList;
+import java.util.NoSuchElementException;
+import java.util.concurrent.Executor;
/**
* Test CronetUrlRequestContext.
@@ -79,6 +82,46 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
}
}
+ static class TestExecutor implements Executor {
+ private final LinkedList<Runnable> mTaskQueue = new LinkedList<Runnable>();
+
+ @Override
+ public void execute(Runnable task) {
+ mTaskQueue.add(task);
+ }
+
+ public void runAllTasks() {
+ try {
+ while (mTaskQueue.size() > 0) {
+ mTaskQueue.remove().run();
+ }
+ } catch (NoSuchElementException e) {
+ }
+ }
+ }
+
+ static class TestNetworkQualityObserver
+ implements NetworkQualityRttObserver, NetworkQualityThroughputObserver {
+ int mRttObservationCount;
+ int mThroughputObservationCount;
+
+ public void onRttObservation(int rttMs, long when, int source) {
+ mRttObservationCount++;
+ }
+
+ public void onThroughputObservation(int throughputKbps, long when, int source) {
+ mThroughputObservationCount++;
+ }
+
+ public int rttObservationCount() {
+ return mRttObservationCount;
+ }
+
+ public int throughputObservationCount() {
+ return mThroughputObservationCount;
+ }
+ }
+
@SmallTest
@Feature({"Cronet"})
public void testConfigUserAgent() throws Exception {
@@ -154,6 +197,65 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
@SmallTest
@Feature({"Cronet"})
+ public void testRealTimeNetworkQualityObservationsNotEnabled() throws Exception {
+ mActivity = launchCronetTestApp();
+ TestNetworkQualityObserver networkQualityObserver = new TestNetworkQualityObserver();
+ mActivity.mUrlRequestContext.addRttObserver(networkQualityObserver);
+ mActivity.mUrlRequestContext.addThroughputObserver(networkQualityObserver);
+ TestUrlRequestListener listener = new TestUrlRequestListener();
+ UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+ TEST_URL, listener, listener.getExecutor());
+ urlRequest.start();
+ listener.blockForDone();
+ assertEquals(0, networkQualityObserver.rttObservationCount());
+ assertEquals(0, networkQualityObserver.throughputObservationCount());
+ mActivity.mUrlRequestContext.shutdown();
+ }
+
+ @SmallTest
+ @Feature({"Cronet"})
+ public void testRealTimeNetworkQualityObservationsObserverRemoved() throws Exception {
+ mActivity = launchCronetTestApp();
+ TestExecutor testExecutor = new TestExecutor();
+ TestNetworkQualityObserver networkQualityObserver = new TestNetworkQualityObserver();
+ mActivity.mUrlRequestContext.enableNetworkQualityEstimator(true, true, testExecutor);
+ mActivity.mUrlRequestContext.addRttObserver(networkQualityObserver);
+ mActivity.mUrlRequestContext.addThroughputObserver(networkQualityObserver);
+ mActivity.mUrlRequestContext.removeRttObserver(networkQualityObserver);
+ mActivity.mUrlRequestContext.removeThroughputObserver(networkQualityObserver);
+ TestUrlRequestListener listener = new TestUrlRequestListener();
+ UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+ TEST_URL, listener, listener.getExecutor());
+ urlRequest.start();
+ listener.blockForDone();
+ testExecutor.runAllTasks();
+ assertEquals(0, networkQualityObserver.rttObservationCount());
+ assertEquals(0, networkQualityObserver.throughputObservationCount());
+ mActivity.mUrlRequestContext.shutdown();
+ }
+
+ @SmallTest
+ @Feature({"Cronet"})
+ public void testRealTimeNetworkQualityObservations() throws Exception {
+ mActivity = launchCronetTestApp();
+ TestExecutor testExecutor = new TestExecutor();
+ TestNetworkQualityObserver networkQualityObserver = new TestNetworkQualityObserver();
+ mActivity.mUrlRequestContext.enableNetworkQualityEstimator(true, true, testExecutor);
+ mActivity.mUrlRequestContext.addRttObserver(networkQualityObserver);
+ mActivity.mUrlRequestContext.addThroughputObserver(networkQualityObserver);
+ TestUrlRequestListener listener = new TestUrlRequestListener();
+ UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+ TEST_URL, listener, listener.getExecutor());
+ urlRequest.start();
+ listener.blockForDone();
+ testExecutor.runAllTasks();
+ assertTrue(networkQualityObserver.rttObservationCount() > 0);
+ assertTrue(networkQualityObserver.throughputObservationCount() > 0);
+ mActivity.mUrlRequestContext.shutdown();
+ }
+
+ @SmallTest
+ @Feature({"Cronet"})
public void testShutdown() throws Exception {
mActivity = launchCronetTestApp();
TestUrlRequestListener listener = new ShutdownTestUrlRequestListener();
« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java ('k') | net/base/network_quality_estimator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698