Added Network Quality Estimator Real-time interface to Cronet

components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import android.content.Context;
 import android.util.Log;
 
 import java.lang.reflect.Constructor;
@@ skipping 76 matching lines @@
      */
     public abstract void startNetLogToFile(String fileName, boolean logAll);
 
     /**
      * Stops NetLog logging and flushes file to disk. If a logging session is
      * not in progress, this call is ignored.
      */
     public abstract void stopNetLog();
 
     /**
+     * Enables the network quality estimator. This must be called before round
+     * trip time and throughput observers are added.
+     * @param executor An executor on which all observers will be called.
+     */
+    public abstract void enableNetworkQualityEstimator(Executor executor);
+
+    /**
+     * Enables the network quality estimator for testing. This must be called
+     * before round trip time and throughput observers are added. Set both
+     * boolean parameters to false for default behavior.
+     * @param useLocalHostRequests Include requests to localhost in estimates.
+     * @param useSmallerResponses Include small responses in throughput estimates.
+     * @param executor An executor on which all observers will be called.
+     */
+    abstract void enableNetworkQualityEstimator(

[pauljensen, 2015/09/02 16:54:48]

@VisibleForTesting?

[bengr, 2015/09/14 21:04:35]

Added to CronetUrlRequestContext.

+            boolean useLocalHostRequests, boolean useSmallerResponses, Executor executor);
+
+    /**
+     * Adds an observer of round trip time observations. This must be called
+     * after the network quality estimator is enabled.

[pauljensen, 2015/09/02 16:54:48]

Can you add an @link to enableNetworkQualityEstimator or replace "the network
quality estimator is enabled" with the @link.  Ditto for addThroughputObserver.

[bengr, 2015/09/14 21:04:35]

Done.

+     * @param observer The observer of round trip times.
+     */
+    public abstract void addRTTObserver(NetworkQualityRTTObserver observer);
+
+    /**
+     * Removes an observer of round trip times if on the observer list. This
+     * should be called after an RTTObserver is added in order to stop
+     * receiving observations.
+     * @param observer The observer of round trip times.
+     */
+    public abstract void removeRTTObserver(NetworkQualityRTTObserver observer);
+
+    /**
+     * Adds an observer of throughout. This must be called after network
+     * quality estimation is enabled.
+     * @param observer The observer of throughput.
+     */
+    public abstract void addThroughputObserver(NetworkQualityThroughputObserver observer);
+
+    /**
+     * Removes an observer of throughput. This should be called after a
+     * ThroughputObserver is added in order to stop receiving observations.
+     * @param observer The observer of throughput.
+     */
+    public abstract void removeThroughputObserver(NetworkQualityThroughputObserver observer);
+
+    /**
      * Creates a {@link UrlRequestContext} with the given
      * {@link UrlRequestContextConfig}.
      * @param context Android {@link Context}.
      * @param config context configuration.
      */
     public static UrlRequestContext createContext(Context context,
             UrlRequestContextConfig config) {
         UrlRequestContext urlRequestContext = null;
         if (config.userAgent().isEmpty()) {
             config.setUserAgent(UserAgent.from(context));
@@ skipping 30 matching lines @@
         } catch (ClassNotFoundException e) {
             // Leave as null.
         } catch (Exception e) {
             throw new IllegalStateException(
                     "Cannot instantiate: " + CRONET_URL_REQUEST_CONTEXT,
                     e);
         }
         return urlRequestContext;
     }
 }