Added Network Quality Estimator Real-time interface to Cronet

components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import android.content.Context;
 import android.util.Log;
 
 import java.lang.reflect.Constructor;
@@ skipping 76 matching lines @@
      */
     public abstract void startNetLogToFile(String fileName, boolean logAll);
 
     /**
      * Stops NetLog logging and flushes file to disk. If a logging session is
      * not in progress, this call is ignored.
      */
     public abstract void stopNetLog();
 
     /**
+     * Enables the network quality estimator. This must be called before RTT

[pauljensen, 2015/09/01 10:59:10]

You abbreviate the first occurrence of RTT but then write out "round trip time"
later.  Please write it out the first time.

[bengr, 2015/09/01 23:07:39]

Done.

+     * and throughput observers are added. Set both parameters to false
+     * for default behavior.
+     * @param useLocalHostRequests Include requests to localhost in estimates.
+     * @param useSmallerResponses Include small responses in throughput estimates.

[pauljensen, 2015/09/01 10:59:10]

AFAIK these parameters are only for testing.  Perhaps we should have a separate
API to enable for testing; it could be either package-private or @hide.

[bengr, 2015/09/01 23:07:39]

Done.

+     */
+    public abstract void enableNetworkQualityEstimator(
+            boolean useLocalHostRequests, boolean useSmallerResponses);
+
+    /**
+     * Adds an observer of round trip time observations.

[pauljensen, 2015/09/01 10:59:10]

Please make this more verbose.  When and under what circumstances does this get
called?  Ditto for the other functions.

[bengr, 2015/09/01 23:07:39]

Done.

+     * @param observer The observer of round trip times.
+     */
+    public abstract void addRTTObserver(NetworkQualityRTTObserver observer);
+
+    /**
+     * Removes an observer of round trip times if on the observer list.
+     * @param observer The observer of round trip times.
+     */
+    public abstract void removeRTTObserver(NetworkQualityRTTObserver observer);
+
+    /**
+     * Adds an observer of throughout.
+     * @param observer The observer of throughput.
+     */
+    public abstract void addThroughputObserver(NetworkQualityThroughputObserver observer);
+
+    /**
+     * Removes an observer of throughput.
+     * @param observer The observer of throughput.
+     */
+    public abstract void removeThroughputObserver(NetworkQualityThroughputObserver observer);
+
+    /**
      * Creates a {@link UrlRequestContext} with the given
      * {@link UrlRequestContextConfig}.
      * @param context Android {@link Context}.
      * @param config context configuration.
      */
     public static UrlRequestContext createContext(Context context,
             UrlRequestContextConfig config) {
         UrlRequestContext urlRequestContext = null;
         if (config.userAgent().isEmpty()) {
             config.setUserAgent(UserAgent.from(context));
@@ skipping 30 matching lines @@
         } catch (ClassNotFoundException e) {
             // Leave as null.
         } catch (Exception e) {
             throw new IllegalStateException(
                     "Cannot instantiate: " + CRONET_URL_REQUEST_CONTEXT,
                     e);
         }
         return urlRequestContext;
     }
 }