src/IceInstX8664.cpp - Issue 1273153002: Subzero. Native 64-bit int arithmetic on x86-64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstX8664.cpp

Issue 1273153002: Subzero. Native 64-bit int arithmetic on x86-64. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fixes tests & make format Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstX8664.cpp

diff --git a/src/IceInstX8664.cpp b/src/IceInstX8664.cpp

index 370918024aadfae5b37e54e7d057baf0d19a6103..49dc9d85c764c0e29372b87f622596f40512ff1f 100644

--- a/src/IceInstX8664.cpp

+++ b/src/IceInstX8664.cpp

@@ -179,8 +179,8 @@ MachineTraits<TargetX8664>::X86OperandMem::toAsmAddress(

Disp = static_cast<int32_t>(CI->getValue());

} else if (const auto CR =

llvm::dyn_cast<ConstantRelocatable>(getOffset())) {

- Disp = CR->getOffset();

- Fixup = Asm->createFixup(llvm::ELF::R_386_32, CR);

+ Disp = CR->getOffset() - 4;

+ Fixup = Asm->createFixup(PcRelFixup, CR);

} else {

llvm_unreachable("Unexpected offset type");

}

« no previous file with comments | « src/IceInstX8632.cpp ('k') | src/IceInstX86Base.h » ('j') | no next file with comments »