src/IceELFSection.h - Issue 1273153002: Subzero. Native 64-bit int arithmetic on x86-64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceELFSection.h

Issue 1273153002: Subzero. Native 64-bit int arithmetic on x86-64. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fixes tests & make format Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceELFSection.h

diff --git a/src/IceELFSection.h b/src/IceELFSection.h

index 5cf89a5287795572b0123557039def15aee9fa5a..961d8d24e3c1dbb1918a0305ec15a524015cacb2 100644

--- a/src/IceELFSection.h

+++ b/src/IceELFSection.h

@@ -362,8 +362,7 @@ void ELFRelocationSection::writeData(const GlobalContext &Ctx, ELFStreamer &Str,

llvm::report_fatal_error("Missing symbol mentioned in reloc");

if (IsELF64) {

- llvm_unreachable(

- "Not tested -- check that Fixup.offset() is correct even for pc-rel");

+ // TODO(jpp): check that Fixup.offset() is correct even for pc-rel.

Elf64_Rela Rela;

Rela.r_offset = Fixup.position();

Rela.setSymbolAndType(Symbol->getNumber(), Fixup.kind());

« no previous file with comments | « src/IceAssemblerX86BaseImpl.h ('k') | src/IceInstX8632.cpp » ('j') | no next file with comments »