Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 1273133002: Make which gold and binutils used configurable. (Closed)

Created:
5 years, 4 months ago by Peter Mayo
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make which gold and binutils used configurable. This allows us to specify the ones from the bundled tools in ChromiumOS, for example. BUG=517497 TEST=None Committed: https://crrev.com/11736e158e8dca479603988a804a6d93b65c4ec7 Cr-Commit-Position: refs/heads/master@{#342208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M build/config/compiler/BUILD.gn View 4 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Peter Mayo
PTAL
5 years, 4 months ago (2015-08-06 16:02:05 UTC) #2
Dirk Pranke
lgtm
5 years, 4 months ago (2015-08-06 20:44:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273133002/1
5 years, 4 months ago (2015-08-06 20:45:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-06 21:53:54 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 21:54:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11736e158e8dca479603988a804a6d93b65c4ec7
Cr-Commit-Position: refs/heads/master@{#342208}

Powered by Google App Engine
This is Rietveld 408576698