Update fancy_urllib to work with python-2.7.10

Update fancy_urllib to work with python-2.7.10

BUG=chromium:517460
R=vapier@chromium.org

https://codereview.chromium.org/1281273002/ landed instead.

[vapier, 2015-08-08 04:38:03]

lgtm

[andreyu, 2015-08-08 19:36:57]

The CQ bit was checked by andreyu@google.com

[commit-bot: I haz the power, 2015-08-08 19:40:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-08 19:40:06]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[andreyu, 2015-08-08 20:20:47]

Looks like this won't commit because I didn't do whatever magic is required for
git-svn to work.

[vapier, 2015-08-09 11:25:11]

try deleting this issue, checking your local .git/config, and make sure it ends
in ".git" in the remote url.  then upload a new one.

[vapier, 2015-08-09 11:31:47]

vapier@chromium.org changed reviewers:
+ agable@chromium.org, petermayo@chromium.org

[vapier, 2015-08-09 11:31:48]

although dcommit failed for me due to missing OWNERS check; let's get an LGTM
from someone in the top level OWNERS file

[Peter Mayo, 2015-08-10 15:54:29]

lgtm

[Peter Mayo, 2015-08-10 16:36:00]

On 2015/08/10 15:54:29, Peter Mayo wrote:
> lgtm

https://codereview.chromium.org/1281273002/ shows the same change with a valid
base_url/project.

I created it by

mkdir <new> ; cd <new>
fetch depot_tools
cd depot_tools
git branch <foo>
git checkout <foo>
apply-issue --issue 1273083004
git commit
git cl upload


(and note that yes, the CQ is quite picky,
https://codereview.chromium.org/1283813002/ seems little different (/ &
project))

[andreyu, 2015-08-10 19:12:46]

On 2015/08/10 16:36:00, Peter Mayo wrote:
> mkdir <new> ; cd <new>
> fetch depot_tools

Here I get this:

AssertionError: Unable to find svn repo for
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Is it because I'm not a chromium committer and not authorized to access
svn.chromium.org?

[Peter Mayo, 2015-08-10 19:34:46]

On 2015/08/10 19:12:46, andreyu wrote:
> On 2015/08/10 16:36:00, Peter Mayo wrote:
> > mkdir <new> ; cd <new>
> > fetch depot_tools
> 
> Here I get this:
> 
> AssertionError: Unable to find svn repo for
> svn://svn.chromium.org/chrome/trunk/tools/depot_tools
> 
> Is it because I'm not a chromium committer and not authorized to access
> svn.chromium.org?

That sounds likely and most unfortunate.  Could you file an infrastructure bug
for that?  I'll re-open my clone of the issue and add you to the review so that
your work can land.

[andreyu, 2015-08-10 19:44:59]

On 2015/08/10 19:34:46, Peter Mayo wrote:
> On 2015/08/10 19:12:46, andreyu wrote:
> That sounds likely and most unfortunate.  Could you file an infrastructure bug
> for that?  

The change already references BUG=chromium:517460. Is that not enough?

> I'll re-open my clone of the issue and add you to the review so that
> your work can land.

Great! Thank you.

[agable, 2015-08-12 22:22:02]

On 2015/08/10 at 19:44:59, andreyu wrote:
> On 2015/08/10 19:34:46, Peter Mayo wrote:
> > On 2015/08/10 19:12:46, andreyu wrote:
> > That sounds likely and most unfortunate.  Could you file an infrastructure
bug
> > for that?  
> 
> The change already references BUG=chromium:517460. Is that not enough?

Different issue. chromium:517460 is for what the CL fixes. You should file a
separate bug to get someone to check your SVN access credentials.

You can check yourself, too: go to chromium-access.appspot.com. Does an SVN
password show up for you? If so, you should have access (even if it isn't write
access) to svn.chromium.org. If not, file a bug. All @googlers should have read
access to svn.chromium.org.
 
> > I'll re-open my clone of the issue and add you to the review so that
> > your work can land.
> 
> Great! Thank you.

[andreyu, 2015-08-12 22:38:04]

On 2015/08/12 22:22:02, agable wrote:
> You can check yourself, too: go to http://chromium-access.appspot.com. Does an
SVN
> password show up for you? If so, you should have access (even if it isn't
write
> access) to http://svn.chromium.org. If not, file a bug. All @googlers should
have read
> access to http://svn.chromium.org.

Going to that page I see the following

"""
andreyu@google.com is not a known user. 

As an open-source project, Chrome treats Googlers the same as other
contributors, and doesn't grant committer access right away. You can get the
source and building instructions from the public repository; see
http://dev.chromium.org/developers. 

If you are requesting committer access, please follow the steps at
http://dev.chromium.org/getting-involved/become-a-committer 

If you are only interested in getting try bot access, please do not request
write access at this time. Read-Only users can submit jobs to the try server. 

If you need access to one of the other internal projects hosted on the svn
server, or if you have good reasons to request access to the internal Chrome
repository, please fill out this form.
"""

"this forms" in the last sentence links to
https://chromium-access.appspot.com/request

[agable, 2015-08-13 17:50:41]

Oh right, I think the read-only version that non-committers all have access to
is src.chromiumm.org, not svn.chromium.org.

[Peter Mayo, 2015-08-13 18:05:55]

+phajdan.jr for open source promotion.

I think the Googler/non-Googler issue is a little bit of a red herring.

Non-committers are supposed to be able fetch public repos and post
suggested fixes to them.

https://code.google.com/p/chromium/issues/detail?id=518949 was filed to
track the fact that that didn't work here.

Lets take any further discussion from this thread and move it to the bug.

On 13 August 2015 at 13:50, <agable@chromium.org> wrote:

> Oh right, I think the read-only version that non-committers all have
> access to
> is src.chromiumm.org, not svn.chromium.org.
>
> https://codereview.chromium.org/1273083004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.