Remove focus event listeners from un-focusable node

chrome/browser/resources/extensions/extension_error.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('extensions', function() {
   'use strict';
 
   /**
    * Clone a template within the extension error template collection.
    * @param {string} templateName The class name of the template to clone.
@@ skipping 41 matching lines @@
     div.__proto__ = ExtensionError.prototype;
     div.decorateWithError_(error, boundary);
     return div;
   }
 
   ExtensionError.prototype = {
     __proto__: cr.ui.FocusRow.prototype,
 
     /** @override */
     getEquivalentElement: function(element) {
       if (element.classList.contains('extension-error-metadata'))

[Dan Beam, 2015/08/11 01:36:21]

as this method would say null.classList

         return this;
       if (element.classList.contains('error-delete-button')) {
         return /** @type {!HTMLElement} */ (this.querySelector(
             '.error-delete-button'));
       }
       assertNotReached();
       return element;
     },
 
     /**
@@ skipping 96 matching lines @@
      * @param {Array<(RuntimeError|ManifestError)>} errors The list of errors.
      */
     decorate: function(errors) {
       /**
        * @private {!Array<(ManifestError|RuntimeError)>}
        */
       this.errors_ = [];
 
       this.focusGrid_ = new cr.ui.FocusGrid();
       this.listContents_ = this.querySelector('.extension-error-list-contents');
-      this.listContents_.addEventListener('focus', this.onFocus_.bind(this));
-      this.listContents_.addEventListener('focusin',
-                                          this.onFocusin_.bind(this));
+
       errors.forEach(this.addError_, this);
 
       this.addEventListener('highlightExtensionError', function(e) {
         this.setActiveErrorNode_(e.target);
       });
       this.addEventListener('deleteExtensionError', function(e) {
         this.removeError_(e.detail);
       });
 
       this.querySelector('#extension-error-list-clear').addEventListener(
@@ skipping 157 matching lines @@
 
       if (node)
         node.classList.add('extension-error-active');
 
       this.activeError_ = node;
 
       this.dispatchEvent(
           new CustomEvent('activeExtensionErrorChanged',
                           {bubbles: true, detail: node ? node.error : null}));
     },
-
-    /**
-     * The grid should not be focusable once it or an element inside it is
-     * focused. This is necessary to allow tabbing out of the grid in reverse.
-     * @private
-     */
-    onFocusin_: function() {
-      this.listContents_.tabIndex = -1;
-    },
-
-    /**
-     * Focus the first focusable row when tabbing into the grid for the
-     * first time.
-     * @private
-     */
-    onFocus_: function() {
-      var activeRow = this.listContents_.querySelector('.focus-row-active');
-      activeRow.getEquivalentElement(null).focus();

[Dan Beam, 2015/08/11 01:36:21]

had this code ever worked, this would blow up ;)

[hcarmona, 2015/08/11 02:03:57]

yup

-    },
   };
 
   return {
     ExtensionErrorList: ExtensionErrorList
   };
 });