Issue 1273023002: Fix WebLocalFrame leaks in unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1273023002: Fix WebLocalFrame leaks in unit tests. (Closed)

Created:
5 years, 4 months ago by sof

Modified:
5 years, 4 months ago

Reviewers:
haraken

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix WebLocalFrame leaks in unit tests. Not calling close() on locally created WebLocalFrames will keep the objects alive on shutdown. Add the required calls to WebViewTest.ClientTapHandlingNullWebViewClient and ParameterizedWebFrameTest.CreateLocalChildWithPreviousSibling. R=haraken BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200103

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -5 lines)			Patch
	M	Source/web/tests/WebFrameTest.cpp	View		2 chunks	+30 lines, -4 lines	0 comments	Download
	M	Source/web/tests/WebViewTest.cpp	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sof

please take a look. Leaks caught by https://codereview.chromium.org/1275863002/

5 years, 4 months ago (2015-08-06 09:41:26 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273023002/1

5 years, 4 months ago (2015-08-06 10:42:13 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-08-06 12:17:36 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200103

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages