net/proxy/proxy_service_mojo_unittest.cc - Issue 1273013004: Returning scoped_ptr<> instead of raw pointer in DhcpProxyScriptFetcherFactory::Create

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_service_mojo_unittest.cc

Issue 1273013004: Returning scoped_ptr<> instead of raw pointer in DhcpProxyScriptFetcherFactory::Create (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/proxy/proxy_service_mojo_unittest.cc

diff --git a/net/proxy/proxy_service_mojo_unittest.cc b/net/proxy/proxy_service_mojo_unittest.cc

index 171f89be8c42f10555272e153014c0d7001d0b38..28ad77b6303e5725a6261b510354bbc5bf2e1682 100644

--- a/net/proxy/proxy_service_mojo_unittest.cc

+++ b/net/proxy/proxy_service_mojo_unittest.cc

@@ -129,8 +129,8 @@ class ProxyServiceMojoTest : public testing::Test,

proxy_service_.reset(CreateProxyServiceUsingMojoFactory(

this, new ProxyConfigServiceFixed(

ProxyConfig::CreateFromCustomPacURL(GURL(kPacUrl))),

- fetcher_, new DoNothingDhcpProxyScriptFetcher(), &mock_host_resolver_,

- &net_log_, &network_delegate_));

+ fetcher_, make_scoped_ptr(new DoNothingDhcpProxyScriptFetcher()),

+ &mock_host_resolver_, &net_log_, &network_delegate_));

}

scoped_ptr<base::ScopedClosureRunner> CreateResolver(

« no previous file with comments | « net/proxy/proxy_service_mojo.cc ('k') | net/proxy/proxy_service_unittest.cc » ('j') | no next file with comments »