Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: net/proxy/dhcp_proxy_script_fetcher_factory.h

Issue 1273013004: Returning scoped_ptr<> instead of raw pointer in DhcpProxyScriptFetcherFactory::Create (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/proxy_service_factory.cc ('k') | net/proxy/dhcp_proxy_script_fetcher_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/dhcp_proxy_script_fetcher_factory.h
diff --git a/net/proxy/dhcp_proxy_script_fetcher_factory.h b/net/proxy/dhcp_proxy_script_fetcher_factory.h
index 147435d6f0bf6a3fb7578aa01daf7d514ff2c395..1c315ad8138c4f1f35989d86da9bf894a7713e98 100644
--- a/net/proxy/dhcp_proxy_script_fetcher_factory.h
+++ b/net/proxy/dhcp_proxy_script_fetcher_factory.h
@@ -9,10 +9,10 @@
#include "base/memory/singleton.h"
#include "net/base/completion_callback.h"
#include "net/base/net_export.h"
+#include "net/proxy/dhcp_proxy_script_fetcher.h"
namespace net {
-class DhcpProxyScriptFetcher;
class URLRequestContext;
// Factory object for creating the appropriate concrete base class of
@@ -34,14 +34,15 @@ class NET_EXPORT DhcpProxyScriptFetcherFactory {
// Creates a new factory object with default settings.
DhcpProxyScriptFetcherFactory();
- // Ownership is transferred to the caller. url_request_context must be valid
- // and its lifetime must exceed that of the returned DhcpProxyScriptFetcher.
+ // url_request_context must be valid and its lifetime must exceed that of the
+ // returned DhcpProxyScriptFetcher.
//
// Note that while a request is in progress, the fetcher may be holding a
// reference to |url_request_context|. Be careful not to create cycles
// between the fetcher and the context; you can break such cycles by calling
// Cancel().
- DhcpProxyScriptFetcher* Create(URLRequestContext* url_request_context);
+ scoped_ptr<DhcpProxyScriptFetcher> Create(
+ URLRequestContext* url_request_context);
// Attempts to enable/disable the DHCP WPAD feature. Does nothing
// if |IsSupported()| returns false.
« no previous file with comments | « chrome/browser/net/proxy_service_factory.cc ('k') | net/proxy/dhcp_proxy_script_fetcher_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698