Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/proxy/proxy_service_mojo_unittest.cc

Issue 1273013004: Returning scoped_ptr<> instead of raw pointer in DhcpProxyScriptFetcherFactory::Create (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/proxy/dhcp_proxy_script_fetcher_factory.cc ('K') | « net/proxy/proxy_service_mojo.cc ('k') | net/proxy/proxy_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_service_mojo_unittest.cc
diff --git a/net/proxy/proxy_service_mojo_unittest.cc b/net/proxy/proxy_service_mojo_unittest.cc
index 171f89be8c42f10555272e153014c0d7001d0b38..b6b6bc86a809a4b4bb3bb2160e3c40b165b52610 100644
--- a/net/proxy/proxy_service_mojo_unittest.cc
+++ b/net/proxy/proxy_service_mojo_unittest.cc
@@ -129,8 +129,9 @@ class ProxyServiceMojoTest : public testing::Test,
proxy_service_.reset(CreateProxyServiceUsingMojoFactory(
this, new ProxyConfigServiceFixed(
ProxyConfig::CreateFromCustomPacURL(GURL(kPacUrl))),
- fetcher_, new DoNothingDhcpProxyScriptFetcher(), &mock_host_resolver_,
- &net_log_, &network_delegate_));
+ fetcher_, scoped_ptr<DhcpProxyScriptFetcher>(
eroman 2015/08/21 20:03:12 optional: use make_scoped_ptr(new DoNothing...);
+ new DoNothingDhcpProxyScriptFetcher()),
+ &mock_host_resolver_, &net_log_, &network_delegate_));
}
scoped_ptr<base::ScopedClosureRunner> CreateResolver(
« net/proxy/dhcp_proxy_script_fetcher_factory.cc ('K') | « net/proxy/proxy_service_mojo.cc ('k') | net/proxy/proxy_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698