Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Side by Side Diff: net/proxy/proxy_service_v8.h

Issue 1273013004: Returning scoped_ptr<> instead of raw pointer in DhcpProxyScriptFetcherFactory::Create (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_PROXY_PROXY_SERVICE_V8_H_ 5 #ifndef NET_PROXY_PROXY_SERVICE_V8_H_
6 #define NET_PROXY_PROXY_SERVICE_V8_H_ 6 #define NET_PROXY_PROXY_SERVICE_V8_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/scoped_ptr.h"
9 #include "net/base/net_export.h" 10 #include "net/base/net_export.h"
11 #include "net/proxy/dhcp_proxy_script_fetcher.h"
10 12
11 namespace net { 13 namespace net {
12 14
13 class DhcpProxyScriptFetcher;
14 class HostResolver; 15 class HostResolver;
15 class NetLog; 16 class NetLog;
16 class NetworkDelegate; 17 class NetworkDelegate;
17 class ProxyConfigService; 18 class ProxyConfigService;
18 class ProxyScriptFetcher; 19 class ProxyScriptFetcher;
19 class ProxyService; 20 class ProxyService;
20 21
21 // Creates a proxy service that polls |proxy_config_service| to notice when 22 // Creates a proxy service that polls |proxy_config_service| to notice when
22 // the proxy settings change. We take ownership of |proxy_config_service|. 23 // the proxy settings change. We take ownership of |proxy_config_service|.
23 // 24 //
24 // |proxy_script_fetcher| specifies the dependency to use for downloading 25 // |proxy_script_fetcher| specifies the dependency to use for downloading
25 // any PAC scripts. The resulting ProxyService will take ownership of it. 26 // any PAC scripts. The resulting ProxyService will take ownership of it.
26 // 27 //
27 // |dhcp_proxy_script_fetcher| specifies the dependency to use for attempting 28 // |dhcp_proxy_script_fetcher| specifies the dependency to use for attempting
28 // to retrieve the most appropriate PAC script configured in DHCP. The 29 // to retrieve the most appropriate PAC script configured in DHCP. The
29 // resulting ProxyService will take ownership of it. 30 // resulting ProxyService will take ownership of it.
eroman 2015/08/19 22:08:39 Please delete this last sentence.
Paritosh Kumar 2015/08/20 15:23:35 Done.
30 // 31 //
31 // |host_resolver| points to the host resolving dependency the PAC script 32 // |host_resolver| points to the host resolving dependency the PAC script
32 // should use for any DNS queries. It must remain valid throughout the 33 // should use for any DNS queries. It must remain valid throughout the
33 // lifetime of the ProxyService. 34 // lifetime of the ProxyService.
34 // 35 //
35 // ########################################################################## 36 // ##########################################################################
36 // # See the warnings in net/proxy/proxy_resolver_v8.h describing the 37 // # See the warnings in net/proxy/proxy_resolver_v8.h describing the
37 // # multi-threading model. In order for this to be safe to use, *ALL* the 38 // # multi-threading model. In order for this to be safe to use, *ALL* the
38 // # other V8's running in the process must use v8::Locker. 39 // # other V8's running in the process must use v8::Locker.
39 // ########################################################################## 40 // ##########################################################################
40 NET_EXPORT ProxyService* CreateProxyServiceUsingV8ProxyResolver( 41 NET_EXPORT ProxyService* CreateProxyServiceUsingV8ProxyResolver(
41 ProxyConfigService* proxy_config_service, 42 ProxyConfigService* proxy_config_service,
42 ProxyScriptFetcher* proxy_script_fetcher, 43 ProxyScriptFetcher* proxy_script_fetcher,
43 DhcpProxyScriptFetcher* dhcp_proxy_script_fetcher, 44 scoped_ptr<DhcpProxyScriptFetcher> dhcp_proxy_script_fetcher,
44 HostResolver* host_resolver, 45 HostResolver* host_resolver,
45 NetLog* net_log, 46 NetLog* net_log,
46 NetworkDelegate* network_delegate); 47 NetworkDelegate* network_delegate);
47 48
48 } // namespace net 49 } // namespace net
49 50
50 #endif // NET_PROXY_PROXY_SERVICE_V8_H_ 51 #endif // NET_PROXY_PROXY_SERVICE_V8_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698