Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 12730017: Merge 184467 "Instant: Don't commit unless the page supports Ins..." (Closed)

Created:
7 years, 9 months ago by sreeram
Modified:
7 years, 9 months ago
Reviewers:
sreeram
CC:
chromium-reviews, melevin, samarth, gideonwald, dominich, David Black, Jered
Visibility:
Public.

Description

Merge 184467 "Instant: Don't commit unless the page supports Ins..." > Instant: Don't commit unless the page supports Instant. > > BUG=177948 > R=samarth@chromium.org > TBR=shishir@chromium.org > TEST=Follow these steps: > 1. Install the Google search app. > 2. Enable Instant from chrome://settings. > 3. Make sure you are signed in so that http://goto.google.com/instant-redirect works. > 4. Start chrome with --instant-url="http://goto.google.com/instant-redirect". > Before: Infinite loop of loading and committing google.com > After: No infinite loop. > > > Review URL: https://chromiumcodereview.appspot.com/12334072 TBR=sreeram@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M chrome/browser/instant/instant_loader.cc View 3 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sreeram
7 years, 9 months ago (2013-03-12 01:06:30 UTC) #1
sreeram
7 years, 9 months ago (2013-03-12 01:07:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r187440.

Powered by Google App Engine
This is Rietveld 408576698