content/common/websocket.h - Issue 12730003: Add IPC for new WebSocket impl.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/websocket.h

Issue 12730003: Add IPC for new WebSocket impl. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_COMMON_WEBSOCKET_H_

	6 #define CONTENT_COMMON_WEBSOCKET_H_

	7

	8 namespace content {

	9

	10 enum WebSocketMessageType {
	jam 2013/05/31 17:45:41 nit: add a comment describing this enum nit: add a comment describing this enum Adam Rice 2013/06/07 07:39:49 Done. Show quoted text On 2013/05/31 17:45:41, jam wrote: > nit: add a comment describing this enum Done.
	11 kWebSocketContinuation = 0x0,
	jam 2013/05/31 17:45:41 per http://www.chromium.org/developers/coding-styl per http://www.chromium.org/developers/coding-style, "Though the Google C++ Style Guide now says to use kConstantNaming for enums, Chromium was written using MACRO_STYLE naming. Continue to use this style for consistency." so this needs to be WEB_SOCKET_MESSAGE_TYPE_CONTINUATION, WEB_SOCKET_MESSAGE_TYPE_TEXT, WEB_SOCKET_MESSAGE_TYPE_BINARY, (in content, we have a convention that the prefix is the name of the enum) Adam Rice 2013/06/07 07:39:49 Done. Show quoted text On 2013/05/31 17:45:41, jam wrote: > per http://www.chromium.org/developers/coding-style, "Though the Google C++ > Style Guide now says to use kConstantNaming for enums, Chromium was written > using MACRO_STYLE naming. Continue to use this style for consistency." > > so this needs to be > WEB_SOCKET_MESSAGE_TYPE_CONTINUATION, > WEB_SOCKET_MESSAGE_TYPE_TEXT, > WEB_SOCKET_MESSAGE_TYPE_BINARY, > > (in content, we have a convention that the prefix is the name of the enum) Done.
	12 kWebSocketText = 0x1,

	13 kWebSocketBinary = 0x2

	14 };

	15

	16 } // namespace content

	17

	18 #endif // CONTENT_COMMON_WEBSOCKET_H_

OLD	NEW

« no previous file with comments | « content/common/content_message_generator.h ('k') | content/common/websocket_messages.h » ('j') | no next file with comments »