Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1272933004: [heap] Avoid inclusion of objects-visiting-inl.h header. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Avoid inclusion of objects-visiting-inl.h header. R=hpayer@chromium.org Committed: https://crrev.com/02495d54597f071cf7281864df3f89b311113823 Cr-Commit-Position: refs/heads/master@{#30109}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -137 lines) Patch
M src/DEPS View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/objects-visiting.cc View 1 2 chunks +130 lines, -0 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 chunks +0 lines, -133 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-10 18:32:35 UTC) #1
Hannes Payer (out of office)
Awesome! LGTM https://codereview.chromium.org/1272933004/diff/1/src/objects.cc File src/objects.cc (left): https://codereview.chromium.org/1272933004/diff/1/src/objects.cc#oldcode30 src/objects.cc:30: #include "src/heap/objects-visiting-inl.h" yey!
5 years, 4 months ago (2015-08-11 06:07:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1272933004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1272933004/1
5 years, 4 months ago (2015-08-11 10:45:19 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4822)
5 years, 4 months ago (2015-08-11 10:46:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1272933004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1272933004/20001
5 years, 4 months ago (2015-08-11 11:23:24 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-11 11:30:06 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 11:30:25 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/02495d54597f071cf7281864df3f89b311113823
Cr-Commit-Position: refs/heads/master@{#30109}

Powered by Google App Engine
This is Rietveld 408576698