Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1272933002: MD downloads: incorporate UX sync feedback (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD downloads: incorporate UX sync feedback Finished download items with an externally removed file are too short. Make them at least as tall as the icon is wide. R=groby@chromium.org BUG=425626 Committed: https://crrev.com/9302bf904b82902069217e1d95dff12192fd40b0 Cr-Commit-Position: refs/heads/master@{#342053}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/md_downloads/item.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Dan Beam
5 years, 4 months ago (2015-08-06 00:50:18 UTC) #1
groby-ooo-7-16
lgtm
5 years, 4 months ago (2015-08-06 00:51:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1272933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1272933002/1
5 years, 4 months ago (2015-08-06 01:03:29 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/95652)
5 years, 4 months ago (2015-08-06 02:37:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1272933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1272933002/1
5 years, 4 months ago (2015-08-06 02:49:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-06 03:31:45 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 03:32:32 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9302bf904b82902069217e1d95dff12192fd40b0
Cr-Commit-Position: refs/heads/master@{#342053}

Powered by Google App Engine
This is Rietveld 408576698