Issue 127293002: Split macros, etc. from base/basictypes.h into base/macros.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 127293002: Split macros, etc. from base/basictypes.h into base/macros.h. (Closed)

Created:
6 years, 11 months ago by viettrungluu

Modified:
6 years, 8 months ago

Reviewers:
brettw, Nico

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Split macros, etc. from base/basictypes.h into base/macros.h. Document the old-school types as deprecated, now that we use stdint.h everywhere. R=brettw@chromium.org BUG=138542 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243653

Patch Set 2 : add to gypi #

Total comments: 2

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -340 lines)			Patch
M	base/base.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	base/basictypes.h	View		3 chunks	+9 lines, -297 lines	2 comments	Download
A +	base/macros.h	View		2 chunks	+10 lines, -43 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

lgtm https://codereview.chromium.org/127293002/diff/60001/base/basictypes.h File base/basictypes.h (right): https://codereview.chromium.org/127293002/diff/60001/base/basictypes.h#newcode44 base/basictypes.h:44: // DEPRECATED: Please use std::numeric_limits (from <limits>) instead. ...

6 years, 11 months ago (2014-01-08 21:24:03 UTC) #2

viettrungluu

Committed patchset #2 manually as r243653 (presubmit successful).

6 years, 11 months ago (2014-01-08 21:38:57 UTC) #3

Nico

6 years, 8 months ago (2014-04-04 01:07:14 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/127293002/diff/60001/base/basictypes.h
File base/basictypes.h (right):

https://codereview.chromium.org/127293002/diff/60001/base/basictypes.h#newcode44
base/basictypes.h:44: // DEPRECATED: Please use std::numeric_limits (from
<limits>) instead.
On 2014/01/08 21:24:03, brettw wrote:
> BTW the problem with numeric_limits is that it introduces an initializer so
> can't be used for static globals.

+1, just came by to say "this is bad advice as it causes static initializers".

Expand Messages | Collapse Messages

Issue 127293002: Split macros, etc. from base/basictypes.h into base/macros.h. (Closed)

Description

Patch Set 1 #

Patch Set 2 : add to gypi #

Messages