Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: pkg/unittest/lib/html_individual_config.dart

Issue 12729026: fix variable in catch statement (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: down the rabbit hole Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/lib/html_individual_config.dart
diff --git a/pkg/unittest/lib/html_individual_config.dart b/pkg/unittest/lib/html_individual_config.dart
index 2432a55733c6f186df379a1082522b17ffe8ef71..fee9a46e95d86865e0111830f668f9eb26d813ad 100644
--- a/pkg/unittest/lib/html_individual_config.dart
+++ b/pkg/unittest/lib/html_individual_config.dart
@@ -19,23 +19,28 @@ import 'unittest.dart' as unittest;
import 'html_config.dart' as htmlconfig;
class HtmlIndividualConfiguration extends htmlconfig.HtmlConfiguration {
-
- String _noSuchTest = '';
- HtmlIndividualConfiguration(isLayoutTest): super(isLayoutTest);
+ HtmlIndividualConfiguration(bool isLayoutTest): super(isLayoutTest);
void onStart() {
var search = window.location.search;
if (search != '') {
- try {
- for (var parameter in search.substring(1).split('&')) {
- if (parameter.startsWith('group=')) {
- var testGroupName = parameter.split('=')[1];
- unittest.filterTests('^$testGroupName${unittest.groupSep}');
- }
+ var groups = search.substring(1).split('&')
+ .where((p) => p.startsWith('group='))
+ .toList();
+
+ if(!groups.isEmpty) {
+ if(groups.length > 1) {
+ throw 'More than one "group" parameter provided.';
+ }
+
+ var testGroupName = groups.single.split('=')[1];
+ var startsWith = "$testGroupName${unittest.groupSep}";
+ unittest.filterTests((unittest.TestCase tc) =>
+ tc.description.startsWith(startsWith));
+
+ if(unittest.testCases.isEmpty) {
+ throw 'No tests match group "$testGroupName".';
}
- } catch (e) {
- print('tried to match "$testGroupName"');
- print('NO_SUCH_TEST');
}
}
super.onStart();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698