fix variable in catch statement

pkg/unittest/lib/html_individual_config.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * A unit test library for running groups of tests in a browser, instead of the
  * entire test file. This is especially used for large tests files that have
  * many subtests, so we can mark groups as failing at a finer granularity than
  * the entire test file.
  *
  * To use, import this file, and call [useHtmlIndividualConfiguration] at the
  * start of your set sequence. Important constraint: your group descriptions
  * MUST NOT contain spaces.
  */
 library unittest_html_individual_config;
 
 import 'dart:html';
 import 'unittest.dart' as unittest;
 import 'html_config.dart' as htmlconfig;
 
 class HtmlIndividualConfiguration extends htmlconfig.HtmlConfiguration {
-
-  String _noSuchTest = '';
-  HtmlIndividualConfiguration(isLayoutTest): super(isLayoutTest);
+  HtmlIndividualConfiguration(bool isLayoutTest): super(isLayoutTest);
 
   void onStart() {
     var search = window.location.search;
     if (search != '') {
       try {
         for (var parameter in search.substring(1).split('&')) {
           if (parameter.startsWith('group=')) {
             var testGroupName = parameter.split('=')[1];

[Siggi Cherem (dart-lang), 2013/03/22 21:08:17]

would you mind instead pulling out the testGroupName declaration outside the
loop? I think that was what they wanted to show below (or both search +
testGroupName)

[Emily Fortuna, 2013/03/22 22:05:51]

The previous refactor is strange. I think what you want is this:

void onStart() {
  var testGroupName = window.location.search;
  if (testGroupName != '') {
    try {
      for (var parameter in testGroupName.substring(1).split('&')) {
         if (parameter.startsWith('group=')) {
           testGroupName = parameter.split('=')[1];
         }
       }
       unittest.filterTests('^$testGroupName${unittest.groupSep}');
     } catch (e) {
       print('tried to match "$testGroupName"');
       print('NO_SUCH_TEST');
     }

OR, if you like having two separate variables, as Siggi was suggesting:
void onStart() {
  var search = window.location.search;
  var testGroupName;
  if (search != '') {
    try {
      for (var parameter in search.substring(1).split('&')) {
         if (parameter.startsWith('group=')) {
           testGroupName = parameter.split('=')[1];
         }
       }
       if (testGroupName != null) {
         unittest.filterTests('^$testGroupName${unittest.groupSep}');
       }
     } catch (e) {
       print('tried to match "$testGroupName"');
       print('NO_SUCH_TEST');
     }

basically my beef with the previous refactor is since it's in the for loop, it
gives the impression that we might call filterTests multiple times, but it
should only be called once.

but yes, the value in 35 should not be the full "search" string, but the sliced
testGroupName -- that error happens if we try to filter tests and come up with
nothing, so we want what we tried to filter with.

             unittest.filterTests('^$testGroupName${unittest.groupSep}');
           }
         }
       } catch (e) {
-        print('tried to match "$testGroupName"');
+        print('tried to match "$search"');
         print('NO_SUCH_TEST');
       }
     }
     super.onStart();
   }
 }
 
 void useHtmlIndividualConfiguration([bool isLayoutTest = false]) {
   if (unittest.config != null) return;
   unittest.configure(new HtmlIndividualConfiguration(isLayoutTest));
 }