Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: test/cctest/test-parsing.cc

Issue 12729023: first step to remove unsafe handles (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: issue with debug build Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-mark-compact.cc ('k') | test/cctest/test-profile-generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index 3ea1fb1a66cc0081ddb49a78d4f98b1248ad9829..f74c0799b4f52ae5680e301eae61baa0aee0a884 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -29,6 +29,9 @@
#include <stdio.h>
#include <string.h>
+// TODO(dcarney): remove
+#define V8_ALLOW_ACCESS_TO_PERSISTENT_IMPLICIT
+
#include "v8.h"
#include "cctest.h"
@@ -175,7 +178,7 @@ class ScriptResource : public v8::String::ExternalAsciiStringResource {
TEST(Preparsing) {
v8::HandleScope handles(v8::Isolate::GetCurrent());
v8::Persistent<v8::Context> context = v8::Context::New();
- v8::Context::Scope context_scope(context);
+ v8::Context::Scope context_scope(v8::Isolate::GetCurrent(), context);
int marker;
i::Isolate::Current()->stack_guard()->SetStackLimit(
reinterpret_cast<uintptr_t>(&marker) - 128 * 1024);
@@ -541,7 +544,7 @@ void TestCharacterStream(const char* ascii_source,
TEST(CharacterStreams) {
v8::HandleScope handles(v8::Isolate::GetCurrent());
v8::Persistent<v8::Context> context = v8::Context::New();
- v8::Context::Scope context_scope(context);
+ v8::Context::Scope context_scope(v8::Isolate::GetCurrent(), context);
TestCharacterStream("abc\0\n\r\x7f", 7);
static const unsigned kBigStringSize = 4096;
@@ -984,7 +987,7 @@ TEST(ScopePositions) {
};
v8::HandleScope handles(v8::Isolate::GetCurrent());
- v8::Persistent<v8::Context> context = v8::Context::New();
+ v8::Handle<v8::Context> context = v8::Context::New(v8::Isolate::GetCurrent());
v8::Context::Scope context_scope(context);
int marker;
@@ -1243,7 +1246,7 @@ TEST(ParserSync) {
if (i::FLAG_stress_compaction) return;
v8::HandleScope handles(v8::Isolate::GetCurrent());
- v8::Persistent<v8::Context> context = v8::Context::New();
+ v8::Handle<v8::Context> context = v8::Context::New(v8::Isolate::GetCurrent());
v8::Context::Scope context_scope(context);
int marker;
@@ -1284,7 +1287,8 @@ TEST(PreparserStrictOctal) {
v8::internal::FLAG_min_preparse_length = 1; // Force preparsing.
v8::V8::Initialize();
v8::HandleScope scope(v8::Isolate::GetCurrent());
- v8::Context::Scope context_scope(v8::Context::New());
+ v8::Context::Scope context_scope(
+ v8::Context::New(v8::Isolate::GetCurrent()));
v8::TryCatch try_catch;
const char* script =
"\"use strict\"; \n"
« no previous file with comments | « test/cctest/test-mark-compact.cc ('k') | test/cctest/test-profile-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698