Fix bogus right-shifts in Array tests

test/mjsunit/array-splice.js

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 267 matching lines @@
     assertFalse(array.hasOwnProperty(6), "array.hasOwnProperty(6)");
     assertFalse(array.hasOwnProperty(7), "array.hasOwnProperty(7)");
     assertTrue(array.hasOwnProperty(8));
     assertFalse(array.hasOwnProperty(9), "array.hasOwnProperty(9)");
 
     // and now check couple of indices above length.
     assertFalse(array.hasOwnProperty(10), "array.hasOwnProperty(10)");
     assertFalse(array.hasOwnProperty(15), "array.hasOwnProperty(15)");
     assertFalse(array.hasOwnProperty(31), "array.hasOwnProperty(31)");
     assertFalse(array.hasOwnProperty(63), "array.hasOwnProperty(63)");
-    assertFalse(array.hasOwnProperty(2 << 32 - 1),
-                "array.hasOwnProperty(2 << 31 - 1)");
+    assertFalse(array.hasOwnProperty(Math.pow(2, 32) - 2),

[adamk, 2013/03/21 22:22:37]

Wasn't sure what these were supposed to be, happy to change to whatever makes
sense (chose 2^32 - 2 since it's the last valid array index).

+                "array.hasOwnProperty(Math.pow(2, 32) - 2)");
   }
 })();
 
 
 // Now check the case with array of holes and some elements on prototype.
 (function() {
   var len = 9;
 
   var at3 = "@3";
   var at7 = "@7";
@@ skipping 26 matching lines @@
     assertFalse(array.hasOwnProperty(6), "array.hasOwnProperty(6)");
     assertFalse(array.hasOwnProperty(7), "array.hasOwnProperty(7)");
     assertTrue(array.hasOwnProperty(8));
     assertFalse(array.hasOwnProperty(9), "array.hasOwnProperty(9)");
 
     // and now check couple of indices above length.
     assertFalse(array.hasOwnProperty(10), "array.hasOwnProperty(10)");
     assertFalse(array.hasOwnProperty(15), "array.hasOwnProperty(15)");
     assertFalse(array.hasOwnProperty(31), "array.hasOwnProperty(31)");
     assertFalse(array.hasOwnProperty(63), "array.hasOwnProperty(63)");
-    assertFalse(array.hasOwnProperty(2 << 32 - 1),
-                "array.hasOwnProperty(2 << 31 - 1)");
+    assertFalse(array.hasOwnProperty(Math.pow(2, 32) - 2),
+                "array.hasOwnProperty(Math.pow(2, 32) - 2)");
   }
 })();
 
 
 // Check the case of JS builtin .splice()
 (function() {
   for (var i = 0; i < 7; i++) {
     var array = [1, 2, 3, 4];
     Array.prototype[3] = 'foo';  // To force JS builtin.
 
     var spliced = array.splice();
 
     assertEquals([], spliced);
     assertEquals([1, 2, 3, 4], array);
   }
 })();
 
 
 // Check the behaviour when approaching maximal values for length.
 (function() {
   for (var i = 0; i < 7; i++) {
     try {
-      new Array((1 << 32) - 3).splice(-1, 0, 1, 2, 3, 4, 5);
+      new Array(Math.pow(2, 32) - 3).splice(-1, 0, 1, 2, 3, 4, 5);
       throw 'Should have thrown RangeError';
     } catch (e) {
       assertTrue(e instanceof RangeError);
     }
 
     // Check smi boundary
     var bigNum = (1 << 30) - 3;
     var array = new Array(bigNum);
     array.splice(-1, 0, 1, 2, 3, 4, 5, 6, 7);
     assertEquals(bigNum + 7, array.length);
   }
 })();
 
 (function() {
   for (var i = 0; i < 7; i++) {
     var a = [7, 8, 9];
     a.splice(0, 0, 1, 2, 3, 4, 5, 6);
     assertEquals([1, 2, 3, 4, 5, 6, 7, 8, 9], a);
     assertFalse(a.hasOwnProperty(10), "a.hasOwnProperty(10)");
     assertEquals(undefined, a[10]);
   }
 })();