Issue 12729014: Fix bogus right-shifts in Array tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12729014: Fix bogus right-shifts in Array tests (Closed)

Created:
7 years, 9 months ago by adamk

Modified:
7 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev, Michael Starzinger

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix bogus left-shifts in Array tests Committed: https://code.google.com/p/v8/source/detail?r=14050

Patch Set 1 #

Total comments: 1

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	test/mjsunit/array-splice.js	View		3 chunks	+5 lines, -5 lines	1 comment	Download
	M	test/mjsunit/array-unshift.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

adamk

https://codereview.chromium.org/12729014/diff/1/test/mjsunit/array-splice.js File test/mjsunit/array-splice.js (right): https://codereview.chromium.org/12729014/diff/1/test/mjsunit/array-splice.js#newcode288 test/mjsunit/array-splice.js:288: assertFalse(array.hasOwnProperty(Math.pow(2, 32) - 2), Wasn't sure what these were ...

7 years, 9 months ago (2013-03-21 22:22:37 UTC) #2

Jakob Kummerow

You may want to s/right/left/ in the CL description, though ;-)

7 years, 9 months ago (2013-03-22 12:33:21 UTC) #4

adamk

7 years, 9 months ago (2013-03-22 15:05:02 UTC) #5

On 2013/03/22 12:33:21, Jakob wrote:
> You may want to s/right/left/ in the CL description, though ;-)

Ha, fixed, not sure how that got missed...

Expand Messages | Collapse Messages