Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3401)

Unified Diff: chrome/browser/ui/webui/chromeos/login/network_dropdown.cc

Issue 12729002: Add a unified observer to replace NetworkManagerObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix mobile_activator_unittest Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/network_dropdown.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc b/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc
index c3ddec9fec9d25988890ba2e05ff8531aba6c16f..078da998298380fb207c56c57edfdd7068f96a3c 100644
--- a/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc
+++ b/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc
@@ -11,6 +11,7 @@
#include "chrome/browser/chromeos/cros/cros_library.h"
#include "chrome/browser/chromeos/login/base_login_display_host.h"
#include "chrome/browser/chromeos/login/login_display_host.h"
+#include "chrome/browser/chromeos/net/connectivity_state_helper.h"
#include "content/public/browser/web_ui.h"
#include "ui/base/models/menu_model.h"
#include "ui/gfx/font.h"
@@ -114,7 +115,7 @@ NetworkDropdown::NetworkDropdown(content::WebUI* web_ui,
network_menu_.reset(new NetworkMenuWebUI(this, web_ui));
network_icon_.reset(
new NetworkMenuIcon(this, NetworkMenuIcon::DROPDOWN_MODE));
- CrosLibrary::Get()->GetNetworkLibrary()->AddNetworkManagerObserver(this);
+ ConnectivityStateHelper::Get()->AddNetworkManagerObserver(this);
CrosLibrary::Get()->GetNetworkLibrary()->RequestNetworkScan();
stevenjb 2013/03/11 23:11:05 If we add RequestScan() to ConnectivityStateHelper
gauravsh 2013/03/12 00:30:25 See my comment in mobile_activator. This shouldn't
gauravsh 2013/03/12 18:18:10 Actually, RequestScan() is simple to add, so did s
Refresh();
network_scan_timer_.Start(FROM_HERE,
@@ -123,7 +124,7 @@ NetworkDropdown::NetworkDropdown(content::WebUI* web_ui,
}
NetworkDropdown::~NetworkDropdown() {
- CrosLibrary::Get()->GetNetworkLibrary()->RemoveNetworkManagerObserver(this);
+ ConnectivityStateHelper::Get()->RemoveNetworkManagerObserver(this);
}
void NetworkDropdown::SetLastNetworkType(ConnectionType last_network_type) {
@@ -146,7 +147,7 @@ bool NetworkDropdown::ShouldOpenButtonOptions() const {
return !oobe_;
}
-void NetworkDropdown::OnNetworkManagerChanged(NetworkLibrary* cros) {
+void NetworkDropdown::NetworkManagerChanged() {
Refresh();
}

Powered by Google App Engine
This is Rietveld 408576698