Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: common/logdog/protocol/butler.proto

Issue 1272893004: LogDog: Update protobufs, add support library. (Closed) Base URL: https://github.com/luci/luci-go@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | common/logdog/protocol/butler.pb.go » ('j') | common/logdog/protocol/protoutil/utils.go » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: common/logdog/protocol/butler.proto
diff --git a/common/logdog/protocol/butler.proto b/common/logdog/protocol/butler.proto
index aaea291e03fa96f3142f0eb4a3291c386823da7f..cf16766b06c1fa5be17aadb653d1a1a5bf603e69 100644
--- a/common/logdog/protocol/butler.proto
+++ b/common/logdog/protocol/butler.proto
@@ -8,6 +8,26 @@ import "log.proto";
import "types.proto";
/*
+ * ButlerMetadata appears as a frame at the beginning of Butler published data
+ * to describe the remainder of the contents.
tandrii(chromium) 2015/08/11 17:41:37 I'm not sure that's the best way to achieve what y
dnj 2015/08/11 18:20:37 What do you mean?
+ */
+message ButlerMetadata {
+ /*
+ * This enumerates the possible contents of published Butler data.
+ */
+ enum ContentType {
+ /* The published data is a ButlerLogBundle protobuf message. */
+ ButlerLogBundle = 1;
+ }
+ /* This is the type of data in the subsequent frame. */
+ optional ContentType type = 1;
+
+ /* If true, the content data is compressed. */
+ optional bool compressed = 2;
+}
+
+
+/*
* A message containing log data in transit from the Butler.
*
* The Butler is capable of conserving bandwidth by bundling collected log
@@ -78,12 +98,18 @@ message ButlerLogBundle {
optional bool terminal = 3;
/*
+ * If terminal is true, this is the terminal stream index; that is, the last
+ * message index in the stream.
+ */
+ optional uint64 terminal_index = 4;
+
+ /*
* Log entries attached to this record. These must be sequential and in
* order.
*
* This is the main log entry content.
*/
- repeated protocol.LogEntry logs = 4;
+ repeated protocol.LogEntry logs = 5;
}
/**
« no previous file with comments | « no previous file | common/logdog/protocol/butler.pb.go » ('j') | common/logdog/protocol/protoutil/utils.go » ('J')

Powered by Google App Engine
This is Rietveld 408576698