Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1272893004: LogDog: Update protobufs, add support library. (Closed)

Created:
5 years, 4 months ago by dnj
Modified:
5 years, 3 months ago
CC:
chromium-reviews, todd, andrew.wang, M-A Ruel, tandrii(chromium)
Base URL:
https://github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

LogDog: Update protobufs, add support library. - Add Protobuf support library. - Add ButlerMetadata message to act as a header frame for published log data. - Published logs from the same Butler instance will now share a secret. - Explicitly track the index of a stream's terminal log entry. - Avoid 64-bit integers in protocol, as Javascript hates them. - Indices and offsets are now 32-bit. - Time is now a RFC3339 string instead of a seconds-from-epoch offset. - Time offsets are now a second/nanosecond pair. - Wrap data blob arrays in a separate message to avoid [][]byte types. - Add JSON marshal/unmarshal to StreamName type. R=iannucci@chromium.org Committed: https://github.com/luci/luci-go/commit/6e402c6cb3f7a3e1032e1941bf2340cb310cb777

Patch Set 1 #

Total comments: 6

Patch Set 2 : Added some more methods. #

Patch Set 3 : Update types. #

Total comments: 1

Patch Set 4 : Update comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+409 lines, -90 lines) Patch
M common/logdog/protocol/butler.proto View 1 2 3 4 chunks +44 lines, -18 lines 0 comments Download
M common/logdog/protocol/butler.pb.go View 1 2 3 8 chunks +97 lines, -23 lines 0 comments Download
M common/logdog/protocol/log.proto View 1 2 6 chunks +12 lines, -9 lines 0 comments Download
M common/logdog/protocol/log.pb.go View 1 2 4 chunks +43 lines, -27 lines 0 comments Download
A common/logdog/protocol/protoutil/doc.go View 1 1 chunk +10 lines, -0 lines 0 comments Download
A common/logdog/protocol/protoutil/utils.go View 1 2 1 chunk +117 lines, -0 lines 0 comments Download
M common/logdog/protocol/types.proto View 1 2 1 chunk +13 lines, -5 lines 0 comments Download
M common/logdog/protocol/types.pb.go View 1 2 2 chunks +34 lines, -8 lines 0 comments Download
M common/logdog/types/streamname.go View 1 2 3 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dnj
PTAL. This is a small update to the LogDog protobuf: - Add "terminal index" field, ...
5 years, 4 months ago (2015-08-07 17:06:29 UTC) #2
tandrii(chromium)
https://codereview.chromium.org/1272893004/diff/1/common/logdog/protocol/butler.proto File common/logdog/protocol/butler.proto (right): https://codereview.chromium.org/1272893004/diff/1/common/logdog/protocol/butler.proto#newcode12 common/logdog/protocol/butler.proto:12: * to describe the remainder of the contents. I'm ...
5 years, 4 months ago (2015-08-11 17:41:37 UTC) #4
dnj
New update includes a few more utility methods. https://codereview.chromium.org/1272893004/diff/1/common/logdog/protocol/butler.proto File common/logdog/protocol/butler.proto (right): https://codereview.chromium.org/1272893004/diff/1/common/logdog/protocol/butler.proto#newcode12 common/logdog/protocol/butler.proto:12: * ...
5 years, 4 months ago (2015-08-11 18:20:37 UTC) #5
dnj
(Ping)
5 years, 3 months ago (2015-08-26 17:09:13 UTC) #7
iannucci
lgtm https://chromiumcodereview.appspot.com/1272893004/diff/40001/common/logdog/protocol/butler.proto File common/logdog/protocol/butler.proto (right): https://chromiumcodereview.appspot.com/1272893004/diff/40001/common/logdog/protocol/butler.proto#newcode59 common/logdog/protocol/butler.proto:59: * The log stream's secret value (required). log ...
5 years, 3 months ago (2015-08-26 18:33:33 UTC) #8
dnj
5 years, 3 months ago (2015-08-26 18:40:45 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
6e402c6cb3f7a3e1032e1941bf2340cb310cb777 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698