chrome/browser/android/popular_sites.h - Issue 1272883004: Popular sites on the NTP: Favicons!

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/popular_sites.h

Issue 1272883004: Popular sites on the NTP: Favicons! (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@enable_popular_sites

Patch Set: review2 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/popular_sites.h

diff --git a/chrome/browser/android/popular_sites.h b/chrome/browser/android/popular_sites.h

index 64f66ce6005e7da5230a5cf187fff58ad8df3346..017b0c61bbdba9f205be843c312a2e740ef6e720 100644

--- a/chrome/browser/android/popular_sites.h

+++ b/chrome/browser/android/popular_sites.h

@@ -30,10 +30,11 @@ class FileDownloader;

class PopularSites {

public:

struct Site {

- Site(const base::string16& title, const GURL& url);

+ Site(const base::string16& title, const GURL& url, const GURL& favicon_url);

base::string16 title;

GURL url;

+ GURL favicon_url;

};

using FinishedCallback = base::Callback<void(bool /* success */)>;