chrome/browser/android/favicon_helper.h - Issue 1272883004: Popular sites on the NTP: Favicons!

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/favicon_helper.h

Issue 1272883004: Popular sites on the NTP: Favicons! (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@enable_popular_sites

Patch Set: review2 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/favicon_helper.h

diff --git a/chrome/browser/android/favicon_helper.h b/chrome/browser/android/favicon_helper.h

index e4afb01148b92139f16cc75e40493751125181b3..3aa3d6ba1cd83594b47aaaddc367cd0741112326 100644

--- a/chrome/browser/android/favicon_helper.h

+++ b/chrome/browser/android/favicon_helper.h

@@ -34,6 +34,13 @@ class FaviconHelper {

jobject obj,

jobject jprofile,

jstring j_page_url);

+ void EnsureFaviconIsAvailable(JNIEnv* env,

+ jobject obj,

+ jobject j_profile,

+ jobject j_web_contents,

+ jstring j_page_url,

+ jstring j_favicon_url,

+ jobject j_availability_callback);

static bool RegisterFaviconHelper(JNIEnv* env);

private: