[turbofan] Remove architecture-specific linkage files and LinkageTraits. Use macro-assembler-define…

[turbofan] Remove architecture-specific linkage files and LinkageTraits. Use macro-assembler-defined constants.

R=mstarzinger@chromium.org
BUG=

Committed: https://crrev.com/7a222c612da7b8fb93569f905515f447072f8a20
Cr-Commit-Position: refs/heads/master@{#30063}

[Michael Starzinger, 2015-08-07 07:59:03]

LGTM.

Is there a particular reason to have five different linkage.cc files with one
method each? I would consider it more intuitive to have all of these methods in
the linkage.cc file instead.

https://codereview.chromium.org/1272883003/diff/1/src/compiler/interpreter-li...
File src/compiler/interpreter-linkage.cc (right):

https://codereview.chromium.org/1272883003/diff/1/src/compiler/interpreter-li...
src/compiler/interpreter-linkage.cc:46: }
nit:

}  // namespace compiler
}  // namespace internal
}  // namespace v8

https://codereview.chromium.org/1272883003/diff/1/src/compiler/js-linkage.cc
File src/compiler/js-linkage.cc (right):

https://codereview.chromium.org/1272883003/diff/1/src/compiler/js-linkage.cc#...
src/compiler/js-linkage.cc:58: }
nit:

}  // namespace compiler
}  // namespace internal
}  // namespace v8

https://codereview.chromium.org/1272883003/diff/1/src/compiler/linkage-impl.h
File src/compiler/linkage-impl.h (right):

https://codereview.chromium.org/1272883003/diff/1/src/compiler/linkage-impl.h...
src/compiler/linkage-impl.h:6: #define V8_COMPILER_LINKAGE_IMPL_H_
Is there still a reason for this file to exist or could the below three
definitions just be moved into the linkage.h file instead?

[titzer, 2015-08-07 10:01:09]

On 2015/08/07 07:59:03, Michael Starzinger wrote:
> LGTM.
> 
> Is there a particular reason to have five different linkage.cc files with one
> method each? I would consider it more intuitive to have all of these methods
in
> the linkage.cc file instead.
> 
>
https://codereview.chromium.org/1272883003/diff/1/src/compiler/interpreter-li...
> File src/compiler/interpreter-linkage.cc (right):
> 
>
https://codereview.chromium.org/1272883003/diff/1/src/compiler/interpreter-li...
> src/compiler/interpreter-linkage.cc:46: }
> nit:
> 
> }  // namespace compiler
> }  // namespace internal
> }  // namespace v8
> 
> https://codereview.chromium.org/1272883003/diff/1/src/compiler/js-linkage.cc
> File src/compiler/js-linkage.cc (right):
> 
>
https://codereview.chromium.org/1272883003/diff/1/src/compiler/js-linkage.cc#...
> src/compiler/js-linkage.cc:58: }
> nit:
> 
> }  // namespace compiler
> }  // namespace internal
> }  // namespace v8
> 
> https://codereview.chromium.org/1272883003/diff/1/src/compiler/linkage-impl.h
> File src/compiler/linkage-impl.h (right):
> 
>
https://codereview.chromium.org/1272883003/diff/1/src/compiler/linkage-impl.h...
> src/compiler/linkage-impl.h:6: #define V8_COMPILER_LINKAGE_IMPL_H_
> Is there still a reason for this file to exist or could the below three
> definitions just be moved into the linkage.h file instead?

Done.

[titzer, 2015-08-07 10:34:06]

The CQ bit was checked by titzer@chromium.org

[titzer, 2015-08-07 10:34:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1272883003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-08-07 10:34:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1272883003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1272883003/20001

[commit-bot: I haz the power, 2015-08-07 10:45:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-07 10:45:56]

Patchset 2 (id:??) landed as
https://crrev.com/7a222c612da7b8fb93569f905515f447072f8a20
Cr-Commit-Position: refs/heads/master@{#30063}