Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1272863003: Componentize protocol_event_observer (Closed)

Created:
5 years, 4 months ago by Abhishek
Modified:
5 years, 4 months ago
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize protocol_event_observer Move protocol_event_observer to sync_driver. BUG=512075 Committed: https://crrev.com/ad5e131d6dcef0917a95996564a0c8c3c833a4cf Cr-Commit-Position: refs/heads/master@{#342325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -45 lines) Patch
M chrome/browser/sync/profile_sync_service.h View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/sync/protocol_event_observer.h View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/sync/protocol_event_observer.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/sync_internals_message_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync_driver.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/sync_driver/protocol_event_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync_driver/protocol_event_observer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Abhishek
PTAL!
5 years, 4 months ago (2015-08-06 06:28:56 UTC) #2
droger
Lgtm Thanks. +zea for owner review.
5 years, 4 months ago (2015-08-06 06:48:59 UTC) #4
Nicolas Zea
lgtm
5 years, 4 months ago (2015-08-06 18:29:51 UTC) #5
Abhishek
+bauerb for chrome/browser/ui/webui/sync_internals_message_handler.h
5 years, 4 months ago (2015-08-07 03:55:20 UTC) #7
Bernhard Bauer
lgtm
5 years, 4 months ago (2015-08-07 07:39:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1272863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1272863003/1
5 years, 4 months ago (2015-08-07 08:14:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 09:32:41 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 09:33:10 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ad5e131d6dcef0917a95996564a0c8c3c833a4cf
Cr-Commit-Position: refs/heads/master@{#342325}

Powered by Google App Engine
This is Rietveld 408576698