Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: remoting/webapp/crd/js/host_daemon_facade.js

Issue 1272833002: Pass error messages from native messaging to web-app. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed unit tests. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/crd/js/host_daemon_facade.js
diff --git a/remoting/webapp/crd/js/host_daemon_facade.js b/remoting/webapp/crd/js/host_daemon_facade.js
index 544abd39683d617c787e344caa5695f963b32a6a..cea917212dc8d0f342fc395b8d0a7b7b0260cf87 100644
--- a/remoting/webapp/crd/js/host_daemon_facade.js
+++ b/remoting/webapp/crd/js/host_daemon_facade.js
@@ -196,7 +196,13 @@ remoting.HostDaemonFacade.prototype.onIncomingMessage_ = function(message) {
try {
var type = base.getStringAttr(message, 'type');
if (type != reply.type) {
- throw 'Expected reply type: ' + reply.type + ', got: ' + type;
+ throw new Error('Expected reply type: ' + reply.type + ', got: ' + type);
+ }
+ var error_message = base.getStringAttr(message, 'error_message', '');
+ if (error_message) {
+ var error_location = base.getStringAttr(message, 'error_location',
+ '<unknown>')
+ console.error(error_message + ' at ' + error_location);
}
reply.deferred.resolve(message);
} catch (/** @type {*} */ e) {

Powered by Google App Engine
This is Rietveld 408576698